From: Matthew Wilcox <matthew@wil.cx>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Al Viro <viro@ftp.linux.org.uk>,
Linus Torvalds <torvalds@osdl.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] timers, pointers to functions and type safety
Date: Sat, 2 Dec 2006 09:02:52 -0700 [thread overview]
Message-ID: <20061202160252.GQ14076@parisc-linux.org> (raw)
In-Reply-To: <1165070713.24604.50.camel@localhost.localdomain>
On Sat, Dec 02, 2006 at 03:45:12PM +0100, Thomas Gleixner wrote:
> What's the cruft ?
>
> struct bla = container_of(timer, struct bla, timer); ???
That's it, right there. Any idea how much we've bloated the kernel with
sysfs, just by insisting that the struct device not be the first item in
the struct? There's any number of 2- and 3- line functions calling each
other, each adding and subtracting constants from the pointers passed to
them. This was a huge mistake, IMO.
next prev parent reply other threads:[~2006-12-02 16:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 17:21 [RFC] timers, pointers to functions and type safety Al Viro
2006-12-02 6:29 ` Daniel Berlin
2006-12-02 12:36 ` Al Viro
2006-12-02 9:23 ` Kyle Moffett
2006-12-02 12:42 ` Al Viro
2006-12-02 20:53 ` Kyle Moffett
2006-12-02 10:47 ` Arnd Bergmann
2006-12-02 12:59 ` Thomas Gleixner
2006-12-02 14:05 ` Al Viro
2006-12-02 14:45 ` Thomas Gleixner
2006-12-02 16:02 ` Matthew Wilcox [this message]
2006-12-02 18:06 ` Thomas Gleixner
2006-12-02 18:19 ` Al Viro
2006-12-02 18:27 ` Thomas Gleixner
2006-12-02 18:40 ` Al Viro
2006-12-02 18:48 ` Al Viro
2006-12-02 21:43 ` Roman Zippel
2006-12-02 21:59 ` Al Viro
2006-12-02 22:13 ` Roman Zippel
2006-12-02 22:40 ` Al Viro
2006-12-02 23:06 ` Roman Zippel
2006-12-03 10:21 ` Pavel Machek
2006-12-03 11:27 ` Russell King
2006-12-03 15:21 ` Roman Zippel
2006-12-03 21:01 ` Pavel Machek
2006-12-03 22:52 ` Roman Zippel
2006-12-03 23:15 ` Pavel Machek
2006-12-04 11:14 ` David Howells
2006-12-04 12:16 ` Russell King
2006-12-04 13:03 ` David Howells
2006-12-04 13:29 ` Russell King
2006-12-04 14:17 ` David Howells
2006-12-04 14:22 ` Russell King
2006-12-04 11:48 ` Ingo Molnar
2006-12-04 12:22 ` David Howells
2006-12-06 0:24 ` Al Viro
2006-12-06 10:20 ` David Howells
2006-12-12 9:59 ` Ingo Molnar
2006-12-02 21:32 ` Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061202160252.GQ14076@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox