* [2.6 patch] FW_LOADER should select HOTPLUG
@ 2006-12-02 19:40 Adrian Bunk
2006-12-03 7:16 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-12-02 19:40 UTC (permalink / raw)
To: linux-kernel
Since FW_LOADER is an option that is always select'ed by the code using
it, it mustn't depend on HOTPLUG.
It's only relevant in the EMBEDDED=y case, but this might have resulted
in illegal FW_LOADER=, HOTPLUG=n configurations.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
@@ -19,8 +19,8 @@
If unsure say Y here.
config FW_LOADER
- tristate "Userspace firmware loading support"
- depends on HOTPLUG
+ tristate
+ select HOTPLUG
---help---
This option is provided for the case where no in-kernel-tree modules
require userspace firmware loading support, but a module built outside
^ permalink raw reply [flat|nested] 6+ messages in thread
* [2.6 patch] FW_LOADER should select HOTPLUG
2006-12-02 19:40 [2.6 patch] FW_LOADER should select HOTPLUG Adrian Bunk
@ 2006-12-03 7:16 ` Adrian Bunk
2006-12-03 8:58 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-12-03 7:16 UTC (permalink / raw)
To: linux-kernel
[ fixed patch below ]
Since FW_LOADER is an option that is always select'ed by the code using
it, it mustn't depend on HOTPLUG.
It's only relevant in the EMBEDDED=y case, but this might have resulted
in illegal FW_LOADER=, HOTPLUG=n configurations.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
@@ -19,8 +19,8 @@
If unsure say Y here.
config FW_LOADER
- tristate "Userspace firmware loading support"
- depends on HOTPLUG
+ tristate
+ select HOTPLUG
---help---
This option is provided for the case where no in-kernel-tree modules
require userspace firmware loading support, but a module built outside
--- linux-2.6.19-rc6-mm2/drivers/pcmcia/Kconfig.old 2006-12-02 21:16:39.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/pcmcia/Kconfig 2006-12-02 21:16:46.000000000 +0100
@@ -6,7 +6,7 @@
config PCCARD
tristate "PCCard (PCMCIA/CardBus) support"
- depends on HOTPLUG
+ select HOTPLUG
---help---
Say Y here if you want to attach PCMCIA- or PC-cards to your Linux
computer. These are credit-card size devices such as network cards,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] FW_LOADER should select HOTPLUG
2006-12-03 7:16 ` Adrian Bunk
@ 2006-12-03 8:58 ` Andrew Morton
2006-12-03 8:15 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2006-12-03 8:58 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sun, 3 Dec 2006 08:16:37 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> Since FW_LOADER is an option that is always select'ed by the code using
> it, it mustn't depend on HOTPLUG.
>
> It's only relevant in the EMBEDDED=y case, but this might have resulted
> in illegal FW_LOADER=, HOTPLUG=n configurations.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
> @@ -19,8 +19,8 @@
> If unsure say Y here.
>
> config FW_LOADER
> - tristate "Userspace firmware loading support"
> - depends on HOTPLUG
> + tristate
> + select HOTPLUG
It would be a retrograde step to start selecting HOTPLUG - we've managed to
avoid it thus far.
It'd be better to make those drivers which select FW_LOADER dependent upon
HOTPLUG.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] FW_LOADER should select HOTPLUG
2006-12-03 8:58 ` Andrew Morton
@ 2006-12-03 8:15 ` Adrian Bunk
2006-12-03 9:24 ` Andrew Morton
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2006-12-03 8:15 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sun, Dec 03, 2006 at 12:58:24AM -0800, Andrew Morton wrote:
> On Sun, 3 Dec 2006 08:16:37 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > Since FW_LOADER is an option that is always select'ed by the code using
> > it, it mustn't depend on HOTPLUG.
> >
> > It's only relevant in the EMBEDDED=y case, but this might have resulted
> > in illegal FW_LOADER=, HOTPLUG=n configurations.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
> > +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
> > @@ -19,8 +19,8 @@
> > If unsure say Y here.
> >
> > config FW_LOADER
> > - tristate "Userspace firmware loading support"
> > - depends on HOTPLUG
> > + tristate
> > + select HOTPLUG
>
> It would be a retrograde step to start selecting HOTPLUG - we've managed to
> avoid it thus far.
$ grep -r "select HOTPLUG" * | wc -l
4
$
> It'd be better to make those drivers which select FW_LOADER dependent upon
> HOTPLUG.
$ grep -r "select FW_LOADER" * | wc -l
71
$
And since the only case where depends<->select makes a difference is
CONFIG_EMBEDDED=y, people will always continue to forget the dependency
on HOTPLUG when select'ing FW_LOADER.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [2.6 patch] FW_LOADER should select HOTPLUG
2006-12-03 8:15 ` Adrian Bunk
@ 2006-12-03 9:24 ` Andrew Morton
2006-12-03 9:17 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Morton @ 2006-12-03 9:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Sun, 3 Dec 2006 09:15:52 +0100
Adrian Bunk <bunk@stusta.de> wrote:
> On Sun, Dec 03, 2006 at 12:58:24AM -0800, Andrew Morton wrote:
> > On Sun, 3 Dec 2006 08:16:37 +0100
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > > Since FW_LOADER is an option that is always select'ed by the code using
> > > it, it mustn't depend on HOTPLUG.
> > >
> > > It's only relevant in the EMBEDDED=y case, but this might have resulted
> > > in illegal FW_LOADER=, HOTPLUG=n configurations.
> > >
> > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > >
> > > --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
> > > +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
> > > @@ -19,8 +19,8 @@
> > > If unsure say Y here.
> > >
> > > config FW_LOADER
> > > - tristate "Userspace firmware loading support"
> > > - depends on HOTPLUG
> > > + tristate
> > > + select HOTPLUG
> >
> > It would be a retrograde step to start selecting HOTPLUG - we've managed to
> > avoid it thus far.
>
> $ grep -r "select HOTPLUG" * | wc -l
> 4
> $
>
> > It'd be better to make those drivers which select FW_LOADER dependent upon
> > HOTPLUG.
>
> $ grep -r "select FW_LOADER" * | wc -l
> 71
46 actually. And it's immaterial.
>
> And since the only case where depends<->select makes a difference is
> CONFIG_EMBEDDED=y, people will always continue to forget the dependency
> on HOTPLUG when select'ing FW_LOADER.
I realise that. But having HOTPLUG magically and mysteriously turn itself
back on again is a pita.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] FW_LOADER should select HOTPLUG
2006-12-03 9:24 ` Andrew Morton
@ 2006-12-03 9:17 ` Adrian Bunk
0 siblings, 0 replies; 6+ messages in thread
From: Adrian Bunk @ 2006-12-03 9:17 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sun, Dec 03, 2006 at 01:24:01AM -0800, Andrew Morton wrote:
> On Sun, 3 Dec 2006 09:15:52 +0100
> Adrian Bunk <bunk@stusta.de> wrote:
>
> > On Sun, Dec 03, 2006 at 12:58:24AM -0800, Andrew Morton wrote:
> > > On Sun, 3 Dec 2006 08:16:37 +0100
> > > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > > Since FW_LOADER is an option that is always select'ed by the code using
> > > > it, it mustn't depend on HOTPLUG.
> > > >
> > > > It's only relevant in the EMBEDDED=y case, but this might have resulted
> > > > in illegal FW_LOADER=, HOTPLUG=n configurations.
> > > >
> > > > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > > >
> > > > --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old 2006-12-02 20:36:49.000000000 +0100
> > > > +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig 2006-12-02 20:37:03.000000000 +0100
> > > > @@ -19,8 +19,8 @@
> > > > If unsure say Y here.
> > > >
> > > > config FW_LOADER
> > > > - tristate "Userspace firmware loading support"
> > > > - depends on HOTPLUG
> > > > + tristate
> > > > + select HOTPLUG
> > >
> > > It would be a retrograde step to start selecting HOTPLUG - we've managed to
> > > avoid it thus far.
> >
> > $ grep -r "select HOTPLUG" * | wc -l
> > 4
> > $
> >
> > > It'd be better to make those drivers which select FW_LOADER dependent upon
> > > HOTPLUG.
> >
> > $ grep -r "select FW_LOADER" * | wc -l
> > 71
>
> 46 actually. And it's immaterial.
Sorry, I had some .old and .orig files in my tree...
> > And since the only case where depends<->select makes a difference is
> > CONFIG_EMBEDDED=y, people will always continue to forget the dependency
> > on HOTPLUG when select'ing FW_LOADER.
>
> I realise that. But having HOTPLUG magically and mysteriously turn itself
> back on again is a pita.
In practice, it's already always turned on (except for CONFIG_EMBEDDED=n).
Unless Kconfig gets changed to automatically inherit dependencies of
select'ed symbols, FW_LOADER not select'ing HOTPLUG is simply a constant
source of bugs.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-03 9:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-02 19:40 [2.6 patch] FW_LOADER should select HOTPLUG Adrian Bunk
2006-12-03 7:16 ` Adrian Bunk
2006-12-03 8:58 ` Andrew Morton
2006-12-03 8:15 ` Adrian Bunk
2006-12-03 9:24 ` Andrew Morton
2006-12-03 9:17 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox