From: Andrew Morton <akpm@osdl.org>
To: minyard@acm.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH 7/12] IPMI: add poll delay
Date: Sun, 3 Dec 2006 13:26:10 -0800 [thread overview]
Message-ID: <20061203132610.471786ca.akpm@osdl.org> (raw)
In-Reply-To: <20061202043520.GC30531@localdomain>
On Fri, 1 Dec 2006 22:35:20 -0600
Corey Minyard <minyard@acm.org> wrote:
> Make sure to delay a little in the IPMI poll routine so we can pass in
> a timeout time and thus time things out.
>
> Signed-off-by: Corey Minyard <minyard@acm.org>
>
> Index: linux-2.6.19-rc6/drivers/char/ipmi/ipmi_si_intf.c
> ===================================================================
> --- linux-2.6.19-rc6.orig/drivers/char/ipmi/ipmi_si_intf.c
> +++ linux-2.6.19-rc6/drivers/char/ipmi/ipmi_si_intf.c
> @@ -807,7 +807,12 @@ static void poll(void *send_info)
> {
> struct smi_info *smi_info = send_info;
>
> - smi_event_handler(smi_info, 0);
> + /*
> + * Make sure there is some delay in the poll loop so we can
> + * drive time forward and timeout things.
> + */
> + udelay(10);
> + smi_event_handler(smi_info, 10);
> }
I don't understand what this patch is doing. It looks fishy. More
details, please?
next prev parent reply other threads:[~2006-12-03 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 4:35 [PATCH 7/12] IPMI: add poll delay Corey Minyard
2006-12-03 21:26 ` Andrew Morton [this message]
2006-12-05 13:43 ` Corey Minyard
2006-12-05 22:40 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061203132610.471786ca.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox