Re: Relative atime (was Re: What's in ocfs2.git)

Andrew Morton
2006-12-06T06:12:05Z

On Tue, 5 Dec 2006 14:20:27 -0800
Mark Fasheh <mark.fasheh@oracle.com> wrote:

> Update ocfs2_should_update_atime() to understand the MNT_RELATIME flag and
> to test against mtime / ctime accordingly.
>
> ...
>
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -154,6 +154,15 @@ int ocfs2_should_update_atime(struct ino
> return 0;
>
> now = CURRENT_TIME;
> +
> + if (vfsmnt->mnt_flags & MNT_RELATIME) {
> + if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) ||
> + (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0))
> + return 1;
> +
> + return 0;

So if atime == mtime == ctime, we don't update the atime.

I think we should. It seems risky to leave them all equal.