Re: [RFC] timers, pointers to functions and type safety

[Russell King <rmk+lkml@arm.linux.org.uk>]

On Mon, Dec 04, 2006 at 01:03:29PM +0000, David Howells wrote:
> Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > I assume you wanted to delete "data" ?
> 
> Yes.
> 
> > Your premise is two timer_lists which use one common handler.
> > 
> > 	struct foo {
> > 		struct timer_list timer1;
> > 		strucr timer_list timer2;
> > 	};
> 
> That's not what I was thinking of.  I was thinking of something much simpler:
> 
> 	struct foo {
> 		struct timer_list timer;
> 	};
> 
> 
> 	...
> 		struct foo *a = kmalloc(sizeof(struct foo), GFP_KERNEL);
> 		a->timer.fn = do_foo_timer;
> 	...
> 		struct foo *b = kmalloc(sizeof(struct foo), GFP_KERNEL);
> 		b->timer.fn = do_foo_timer;
> 	...
> 		struct foo *c = kmalloc(sizeof(struct foo), GFP_KERNEL);
> 		c->timer.fn = do_foo_timer;
> 	...
> 		struct foo *d = kmalloc(sizeof(struct foo), GFP_KERNEL);
> 		d->timer.fn = do_foo_timer;
> 	...
> 
> You've now got four copies of struct timer_list, but only one handler.

<re-insert last paragraph of my message until read, understood and
actioned.>

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of: