* [2.6 patch] USB_RTL8150 must select MII
2006-11-03 2:47 ` David Brownell
@ 2006-11-04 2:51 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-11-04 2:51 UTC (permalink / raw)
To: David Brownell
Cc: Greg KH, Randy Dunlap, toralf.foerster, netdev, linux-usb-devel,
link, akpm, zippel, torvalds, linux-kernel
On Thu, Nov 02, 2006 at 06:47:15PM -0800, David Brownell wrote:
> On Thursday 02 November 2006 6:27 pm, Adrian Bunk wrote:
>
> > It seems to lack the "select MII" at the USB_RTL8150 option that was in
> > Randy's first patch?
>
> I was just addressing the usbnet issues ... that driver doesn't
> use the usbnet framework.
OK, the patch for this driver is below.
> - Dave
cu
Adrian
<-- snip -->
USB_RTL8150 must select MII to avoid link errors.
Stolen from a patch by Randy Dunlap.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2619-rc3-pv.orig/drivers/usb/net/Kconfig
+++ linux-2619-rc3-pv/drivers/usb/net/Kconfig
@@ -84,6 +84,7 @@ config USB_PEGASUS
config USB_RTL8150
tristate "USB RTL8150 based ethernet device support (EXPERIMENTAL)"
depends on EXPERIMENTAL
+ select MII
help
Say Y here if you have RTL8150 based usb-ethernet adapter.
Send me <petkan@users.sourceforge.net> any comments you may have.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] USB_RTL8150 must select MII
@ 2006-12-04 20:02 Adrian Bunk
2006-12-04 23:13 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2006-12-04 20:02 UTC (permalink / raw)
To: Andrew Morton; +Cc: Greg KH, linux-kernel, Randy Dunlap
USB_RTL8150 must select MII to avoid link errors.
Stolen from a patch by Randy Dunlap.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 4 Nov 2006
--- linux-2619-rc3-pv.orig/drivers/usb/net/Kconfig
+++ linux-2619-rc3-pv/drivers/usb/net/Kconfig
@@ -84,6 +84,7 @@ config USB_PEGASUS
config USB_RTL8150
tristate "USB RTL8150 based ethernet device support (EXPERIMENTAL)"
depends on EXPERIMENTAL
+ select MII
help
Say Y here if you have RTL8150 based usb-ethernet adapter.
Send me <petkan@users.sourceforge.net> any comments you may have.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] USB_RTL8150 must select MII
2006-12-04 20:02 [2.6 patch] USB_RTL8150 must select MII Adrian Bunk
@ 2006-12-04 23:13 ` Randy Dunlap
2006-12-05 0:53 ` David Brownell
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2006-12-04 23:13 UTC (permalink / raw)
To: Adrian Bunk, dbrownell; +Cc: Andrew Morton, Greg KH, linux-kernel
On Mon, 4 Dec 2006 21:02:06 +0100 Adrian Bunk wrote:
> USB_RTL8150 must select MII to avoid link errors.
>
> Stolen from a patch by Randy Dunlap.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks, Adrian.
David B. may prefer a patch similar to the one that was
merged for USB_NET_MCS7830, which does:
select USB_USBNET_MII
although I don't see why...
> ---
>
> This patch was already sent on:
> - 4 Nov 2006
>
> --- linux-2619-rc3-pv.orig/drivers/usb/net/Kconfig
> +++ linux-2619-rc3-pv/drivers/usb/net/Kconfig
> @@ -84,6 +84,7 @@ config USB_PEGASUS
> config USB_RTL8150
> tristate "USB RTL8150 based ethernet device support (EXPERIMENTAL)"
> depends on EXPERIMENTAL
> + select MII
> help
> Say Y here if you have RTL8150 based usb-ethernet adapter.
> Send me <petkan@users.sourceforge.net> any comments you may have.
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] USB_RTL8150 must select MII
2006-12-04 23:13 ` Randy Dunlap
@ 2006-12-05 0:53 ` David Brownell
0 siblings, 0 replies; 4+ messages in thread
From: David Brownell @ 2006-12-05 0:53 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Adrian Bunk, dbrownell, Andrew Morton, Greg KH, linux-kernel
On Monday 04 December 2006 3:13 pm, Randy Dunlap wrote:
> On Mon, 4 Dec 2006 21:02:06 +0100 Adrian Bunk wrote:
>
> > USB_RTL8150 must select MII to avoid link errors.
> >
> > Stolen from a patch by Randy Dunlap.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> Thanks, Adrian.
>
> David B. may prefer a patch similar to the one that was
> merged for USB_NET_MCS7830, which does:
>
> select USB_USBNET_MII
No, rtl8150 doesn't use the usbnet framework.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-05 2:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-04 20:02 [2.6 patch] USB_RTL8150 must select MII Adrian Bunk
2006-12-04 23:13 ` Randy Dunlap
2006-12-05 0:53 ` David Brownell
-- strict thread matches above, loose matches on Subject: below --
2006-10-23 23:22 Linux 2.6.19-rc3 Linus Torvalds
2006-11-02 20:29 ` [PATCH 2/2] usbnet: use MII hooks only if CONFIG_MII is enabled David Brownell
2006-11-03 2:27 ` Adrian Bunk
2006-11-03 2:47 ` David Brownell
2006-11-04 2:51 ` [2.6 patch] USB_RTL8150 must select MII Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox