From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968640AbWLETKp (ORCPT ); Tue, 5 Dec 2006 14:10:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S968642AbWLETKp (ORCPT ); Tue, 5 Dec 2006 14:10:45 -0500 Received: from mga05.intel.com ([192.55.52.89]:36365 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968640AbWLETKp (ORCPT ); Tue, 5 Dec 2006 14:10:45 -0500 X-ExtLoop1: 1 X-IronPort-AV: i="4.09,501,1157353200"; d="scan'208"; a="173417198:sNHT36205498" Date: Tue, 5 Dec 2006 10:25:43 -0800 From: Mark Gross To: Akinobu Mita , linux-kernel@vger.kernel.org, Sebastien Bouchard , akpm@osdl.org Subject: Re: [PATCH] tlclk: fix platform_device_register_simple() error check Message-ID: <20061205182543.GA19497@linux.intel.com> Reply-To: mgross@linux.intel.com References: <20061122184111.GC2985@APFDCB5C> <20061127203452.GA12279@linux.intel.com> <20061128060830.GA28689@APFDCB5C> <20061129211757.GB5267@linux.intel.com> <20061202040332.GA22330@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061202040332.GA22330@localhost.localdomain> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 02, 2006 at 01:03:32PM +0900, Akinobu Mita wrote: > On Wed, Nov 29, 2006 at 01:17:57PM -0800, Mark Gross wrote: > > > We expect platform_device_register_simple() returns proper errno as pointer > > > when it fails. > > > > What's wrong with EBUSY? > > -ENOMEM or -EINVAL could be returned by platform_device_register_simple() > logically. And we don't know what kind of change will be made into driver > core in future. Ok, would you like me to ack your earlier patch or will you send a new one? --mgross