public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Mark Fasheh <mark.fasheh@oracle.com>
Cc: linux-kernel@vger.kernel.org, hch@lst.de,
	val_henson@linux.intel.com, viro@zeniv.linux.org.uk
Subject: Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree
Date: Tue, 5 Dec 2006 22:43:11 -0800	[thread overview]
Message-ID: <20061205224311.5dcfaf20.akpm@osdl.org> (raw)
In-Reply-To: <20061206062809.GD4497@ca-server1.us.oracle.com>

On Tue, 5 Dec 2006 22:28:09 -0800
Mark Fasheh <mark.fasheh@oracle.com> wrote:

> >  	if (vfsmnt->mnt_flags & MNT_RELATIME) {
> > -		if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) ||
> > -		    (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0))
> > +		if ((timespec_compare(&inode->i_atime, &inode->i_mtime) <= 0) ||
> > +		    (timespec_compare(&inode->i_atime, &inode->i_ctime) <= 0))
> >  			return 1;
> Hmm, should we fix up touch_atime() to use "<=" as well? Maybe I didn't read
> it correctly...

The logic I have there is the same (I hope)...

+			if (timespec_compare(&inode->i_mtime,
+						&inode->i_atime) < 0 &&
+			    timespec_compare(&inode->i_ctime,
+						&inode->i_atime) < 0)
+				return;


  reply	other threads:[~2006-12-06  6:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200612060612.kB66CjNW025289@shell0.pdx.osdl.net>
2006-12-06  6:28 ` + ocfs2-relative-atime-support-tweaks.patch added to -mm tree Mark Fasheh
2006-12-06  6:43   ` Andrew Morton [this message]
2006-12-06  6:55     ` Mark Fasheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061205224311.5dcfaf20.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.fasheh@oracle.com \
    --cc=val_henson@linux.intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox