From: Mark Fasheh <mark.fasheh@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: mm-commits@vger.kernel.org, akpm@osdl.org, hch@lst.de,
val_henson@linux.intel.com, viro@zeniv.linux.org.uk
Subject: Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree
Date: Tue, 5 Dec 2006 22:28:09 -0800 [thread overview]
Message-ID: <20061206062809.GD4497@ca-server1.us.oracle.com> (raw)
In-Reply-To: <200612060612.kB66CjNW025289@shell0.pdx.osdl.net>
On Tue, Dec 05, 2006 at 10:12:45PM -0800, akpm@osdl.org wrote:
> ------------------------------------------------------
> Subject: ocfs2-relative-atime-support-tweaks
> From: Andrew Morton <akpm@osdl.org>
>
> methinks...
Yeah, all good tweaks - thanks for catching those. And thanks for carrying
the ocfs2 patch in -mm.
Acked-by: Mark Fasheh <mark.fasheh@oracle.com>
> diff -puN fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks fs/ocfs2/file.c
> --- a/fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks
> +++ a/fs/ocfs2/file.c
> @@ -153,16 +153,15 @@ int ocfs2_should_update_atime(struct ino
> ((vfsmnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode)))
> return 0;
>
> - now = CURRENT_TIME;
> -
> if (vfsmnt->mnt_flags & MNT_RELATIME) {
> - if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) ||
> - (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0))
> + if ((timespec_compare(&inode->i_atime, &inode->i_mtime) <= 0) ||
> + (timespec_compare(&inode->i_atime, &inode->i_ctime) <= 0))
> return 1;
Hmm, should we fix up touch_atime() to use "<=" as well? Maybe I didn't read
it correctly...
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
next parent reply other threads:[~2006-12-06 6:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200612060612.kB66CjNW025289@shell0.pdx.osdl.net>
2006-12-06 6:28 ` Mark Fasheh [this message]
2006-12-06 6:43 ` + ocfs2-relative-atime-support-tweaks.patch added to -mm tree Andrew Morton
2006-12-06 6:55 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206062809.GD4497@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=val_henson@linux.intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox