* Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree [not found] <200612060612.kB66CjNW025289@shell0.pdx.osdl.net> @ 2006-12-06 6:28 ` Mark Fasheh 2006-12-06 6:43 ` Andrew Morton 0 siblings, 1 reply; 3+ messages in thread From: Mark Fasheh @ 2006-12-06 6:28 UTC (permalink / raw) To: linux-kernel; +Cc: mm-commits, akpm, hch, val_henson, viro On Tue, Dec 05, 2006 at 10:12:45PM -0800, akpm@osdl.org wrote: > ------------------------------------------------------ > Subject: ocfs2-relative-atime-support-tweaks > From: Andrew Morton <akpm@osdl.org> > > methinks... Yeah, all good tweaks - thanks for catching those. And thanks for carrying the ocfs2 patch in -mm. Acked-by: Mark Fasheh <mark.fasheh@oracle.com> > diff -puN fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks fs/ocfs2/file.c > --- a/fs/ocfs2/file.c~ocfs2-relative-atime-support-tweaks > +++ a/fs/ocfs2/file.c > @@ -153,16 +153,15 @@ int ocfs2_should_update_atime(struct ino > ((vfsmnt->mnt_flags & MNT_NODIRATIME) && S_ISDIR(inode->i_mode))) > return 0; > > - now = CURRENT_TIME; > - > if (vfsmnt->mnt_flags & MNT_RELATIME) { > - if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) || > - (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0)) > + if ((timespec_compare(&inode->i_atime, &inode->i_mtime) <= 0) || > + (timespec_compare(&inode->i_atime, &inode->i_ctime) <= 0)) > return 1; Hmm, should we fix up touch_atime() to use "<=" as well? Maybe I didn't read it correctly... --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree 2006-12-06 6:28 ` + ocfs2-relative-atime-support-tweaks.patch added to -mm tree Mark Fasheh @ 2006-12-06 6:43 ` Andrew Morton 2006-12-06 6:55 ` Mark Fasheh 0 siblings, 1 reply; 3+ messages in thread From: Andrew Morton @ 2006-12-06 6:43 UTC (permalink / raw) To: Mark Fasheh; +Cc: linux-kernel, hch, val_henson, viro On Tue, 5 Dec 2006 22:28:09 -0800 Mark Fasheh <mark.fasheh@oracle.com> wrote: > > if (vfsmnt->mnt_flags & MNT_RELATIME) { > > - if ((timespec_compare(&inode->i_atime, &inode->i_mtime) < 0) || > > - (timespec_compare(&inode->i_atime, &inode->i_ctime) < 0)) > > + if ((timespec_compare(&inode->i_atime, &inode->i_mtime) <= 0) || > > + (timespec_compare(&inode->i_atime, &inode->i_ctime) <= 0)) > > return 1; > Hmm, should we fix up touch_atime() to use "<=" as well? Maybe I didn't read > it correctly... The logic I have there is the same (I hope)... + if (timespec_compare(&inode->i_mtime, + &inode->i_atime) < 0 && + timespec_compare(&inode->i_ctime, + &inode->i_atime) < 0) + return; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: + ocfs2-relative-atime-support-tweaks.patch added to -mm tree 2006-12-06 6:43 ` Andrew Morton @ 2006-12-06 6:55 ` Mark Fasheh 0 siblings, 0 replies; 3+ messages in thread From: Mark Fasheh @ 2006-12-06 6:55 UTC (permalink / raw) To: Andrew Morton; +Cc: linux-kernel, hch, val_henson, viro On Tue, Dec 05, 2006 at 10:43:11PM -0800, Andrew Morton wrote: > The logic I have there is the same (I hope)... > > + if (timespec_compare(&inode->i_mtime, > + &inode->i_atime) < 0 && > + timespec_compare(&inode->i_ctime, > + &inode->i_atime) < 0) > + return; Oh ok, yeah I didn't notice that the arguments to timespec_compare() had been changed! --Mark -- Mark Fasheh Senior Software Developer, Oracle mark.fasheh@oracle.com ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-06 6:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200612060612.kB66CjNW025289@shell0.pdx.osdl.net>
2006-12-06 6:28 ` + ocfs2-relative-atime-support-tweaks.patch added to -mm tree Mark Fasheh
2006-12-06 6:43 ` Andrew Morton
2006-12-06 6:55 ` Mark Fasheh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox