Re: [PATCH 0/3] New firewire stack

Kristian Høgsberg
2006-12-09T19:44:52Z

On 12/8/06, Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> Pavel Machek wrote at linux-kernel:
> > On Tue 05-12-06 17:05:30, Erik Mouw wrote:
> >> On Tue, Dec 05, 2006 at 10:13:55AM -0500, Kristian H?gsberg wrote:
> >> > Marcel Holtmann wrote:
> >> > >can you please use drivers/firewire/ if you want to start clean or
> >> > >aiming at replacing drivers/ieee1394/. Using "fw" as an abbreviation in
> >> > >the directory path is not really helpful.
> >> >
> >> > Yes, that's probably a better idea. Do you see a problem with using fw_*
> >> > as a prefix in the code though? I don't see anybody using that prefix, but
> >> > Stefan pointed out to me that it's often used to abbreviate firmware too.
> >>
> >> So what about fiwi_*? If that's too close to wifi_*, try frwr_.
> >
> > Ugly, but fwire could be acceptable.
>
> How about this:
> Let's let Kristian continue to work with his chosen fw_ prefix until his
> drivers are ready to be pulled in (into the linux1394 repo and -mm),
> then make a decision about prefixes. It's mostly a matter of running sed
> over the files.

Yeah, I'm not changing it just yet, but I'm not too attached to fw_
and I think that ieee1394_ will work better. The modutil tools
already use ieee1394 for device_id tables.

> Regarding the directory name, I favor to stick everything into
> drivers/ieee1394 even if it could get crowded during a transition period.

Yeah, if we're going with the ieee1394 prefix, it'd make the most
sense if the files live in drivers/ieee1394.

Kristian