Re: [PATCH 3/3] Import fw-sbp2 driver.

Kristian Høgsberg
2006-12-15T15:11:12Z

Stefan Richter wrote:
> Kristian Høgsberg wrote:
>> Jeff Garzik wrote:
>>> doesn't allowing the stack to issue REPORT LUNS take care of this?
>> Possibly, I don't have firewire multi-LUN devices to test with here.
>> The LUNs are also discoverable from the firewire config rom, which is
>> why I put the comment there. This doesn't mean that the SCSI commands
>> for discovering LUNs doesn't also work.
>
> I expect REPORT LUNS won't work for many SBP-2 devices. It is not included
> in RBC.
>
> We discover LUs properly from the information in the ISO 13213 ROM. We just
> don't map multiple LUs of the same target to scsi_device's beneath a single
> scsi_target. (We instantiate one Scsi_Host for each LU. I might implement
> a respective mapping some day, but there is no bigger benefit of doing so.)

Yeah, I saw that the stack creates a struct device per LUN, which is kinda
gross in my opinion. It's easy enough to discover the LUNs from the rom, I
just need to figure out how to tell the SCSI stack about multiple LUNs.

Kristian