Re: [PATCH 2/3] Import fw-ohci driver.

Kristian Høgsberg
2006-12-10T21:48:50Z

Stefan Richter wrote:
> Kristian Høgsberg wrote:
>> Yup, I've done away with the bitfields and switched to a mix of __le16
>> and __le32 struct fields.
>
> I suppose the struct should get __attribute__((packed)) then.

I guess it wouldn't harm, but is it really necessary? Would gcc ever insert
padding here, all the 32 bit fields a 32 bit aligned, and so are the 16 bit
fields.

> But is the order of two adjacent __le16 fields (i.e. two halves of a
> quadlet) independent of host byte order?

Yeah, it works for both be and le cpus. The layout is le specific, which is
how the host controller wants it.

cheers,
Kristian