From: Andrew Morton <akpm@osdl.org>
To: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
trevor.highland@gmail.com, tyhicks@ou.edu
Subject: Re: [PATCH 2/2] eCryptfs: Public key; packet management
Date: Wed, 6 Dec 2006 21:57:48 -0800 [thread overview]
Message-ID: <20061206215748.de51dc59.akpm@osdl.org> (raw)
In-Reply-To: <20061206231236.GB9358@us.ibm.com>
On Wed, 6 Dec 2006 17:12:37 -0600
Michael Halcrow <mhalcrow@us.ibm.com> wrote:
> Public key support code. This reads and writes packets in the header
> that contain public key encrypted file keys. It calls the messaging
> code in the previous patch to send and receive encryption and
> decryption request packets from the userspace daemon.
>
> ...
>
> + memset(auth_tok_list_item, 0,
> + sizeof(struct ecryptfs_auth_tok_list_item));
> + kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> + auth_tok_list_item);
>
> ...
>
> + memset(auth_tok_list_item, 0,
> + sizeof(struct ecryptfs_auth_tok_list_item));
> + kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> + auth_tok_list_item);
That's a bit wasteful of cycles. Or is this done to minimise the exposure
of sensitive data? If so, a comment would be in order.
next prev parent reply other threads:[~2006-12-07 5:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 23:06 [PATCH 1/2] eCryptfs: Public key; transport mechanism Michael Halcrow
2006-12-06 23:12 ` [PATCH 2/2] eCryptfs: Public key; packet management Michael Halcrow
2006-12-07 5:57 ` Andrew Morton [this message]
2006-12-07 5:55 ` [PATCH 1/2] eCryptfs: Public key; transport mechanism Andrew Morton
2006-12-07 16:06 ` Michael Halcrow
2006-12-09 19:04 ` Randy Dunlap
2006-12-09 19:21 ` Andrew Morton
2006-12-09 19:50 ` Randy Dunlap
2006-12-12 16:54 ` Michael Halcrow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061206215748.de51dc59.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=trevor.highland@gmail.com \
--cc=tyhicks@ou.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox