public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] lockdep: use chain hash on CONFIG_DEBUG_LOCKDEP too
@ 2006-12-07  9:32 Ingo Molnar
  0 siblings, 0 replies; only message in thread
From: Ingo Molnar @ 2006-12-07  9:32 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

Subject: [patch] lockdep: use chain hash on CONFIG_DEBUG_LOCKDEP too
From: Ingo Molnar <mingo@elte.hu>

CONFIG_DEBUG_LOCKDEP is unacceptably slow because it does not utilize 
the chain-hash. Turn the chain-hash back on in this case too.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/lockdep.c |    8 --------
 1 file changed, 8 deletions(-)

Index: linux/kernel/lockdep.c
===================================================================
--- linux.orig/kernel/lockdep.c
+++ linux/kernel/lockdep.c
@@ -1278,14 +1278,6 @@ static inline int lookup_chain_cache(u64
 		if (chain->chain_key == chain_key) {
 cache_hit:
 			debug_atomic_inc(&chain_lookup_hits);
-			/*
-			 * In the debugging case, force redundant checking
-			 * by returning 1:
-			 */
-#ifdef CONFIG_DEBUG_LOCKDEP
-			__raw_spin_lock(&hash_lock);
-			return 1;
-#endif
 			if (very_verbose(class))
 				printk("\nhash chain already cached, key: %016Lx tail class: [%p] %s\n", chain_key, class->key, class->name);
 			return 0;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-12-07  9:33 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-07  9:32 [patch] lockdep: use chain hash on CONFIG_DEBUG_LOCKDEP too Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox