From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jeff@garzik.org>,
torvalds@osdl.org, macro@linux-mips.org,
David Howells <dhowells@redhat.com>,
rdreier@cisco.com, afleming@freescale.com,
ben.collins@ubuntu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Export current_is_keventd() for libphy
Date: Thu, 7 Dec 2006 10:17:41 -0800 [thread overview]
Message-ID: <20061207101741.25fe647c.akpm@osdl.org> (raw)
In-Reply-To: <20061207095715.0cafffb9.akpm@osdl.org>
On Thu, 7 Dec 2006 09:57:15 -0800
Andrew Morton <akpm@osdl.org> wrote:
> On Thu, 07 Dec 2006 12:05:38 -0500
> Jeff Garzik <jeff@garzik.org> wrote:
>
> > Yes, I merged the code, but looking deeper at phy its clear I missed
> > some things.
> >
> > Looking into libphy's workqueue stuff, it has the following sequence:
> >
> > disable interrupts
> > schedule_work()
> >
> > ... time passes ...
> > ... workqueue routine is called ...
> >
> > enable interrupts
> > handle interrupt
> >
> > I really have to question if a workqueue was the best choice of
> > direction for such a sequence. You don't want to put off handling an
> > interrupt, with interrupts disabled, for a potentially unbounded amount
> > of time.
>
> That'll lock the box on UP, or if the timer fires on the current CPU?
oh. "disable interrupts" == disable_irq(), not local_irq_disable()?
Not so bad ;)
next prev parent reply other threads:[~2006-12-07 18:19 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 5:50 [PATCH] Export current_is_keventd() for libphy Ben Collins
2006-12-03 9:16 ` Andrew Morton
2006-12-04 19:17 ` Steve Fox
2006-12-05 18:05 ` Maciej W. Rozycki
2006-12-05 17:48 ` Maciej W. Rozycki
2006-12-05 18:07 ` Linus Torvalds
2006-12-05 19:31 ` Andrew Morton
2006-12-05 18:57 ` Andy Fleming
2006-12-06 12:31 ` Maciej W. Rozycki
2006-12-05 20:39 ` Andrew Morton
2006-12-05 20:59 ` Andy Fleming
2006-12-05 21:26 ` Andrew Morton
2006-12-05 21:37 ` Roland Dreier
2006-12-05 21:57 ` Andrew Morton
2006-12-05 23:49 ` Roland Dreier
2006-12-05 23:52 ` Roland Dreier
2006-12-06 15:25 ` Maciej W. Rozycki
2006-12-06 15:57 ` Andrew Morton
2006-12-06 17:17 ` Linus Torvalds
2006-12-06 17:43 ` David Howells
2006-12-06 17:50 ` Jeff Garzik
2006-12-06 18:07 ` Linus Torvalds
2006-12-06 17:53 ` Linus Torvalds
2006-12-06 17:58 ` Linus Torvalds
2006-12-06 18:33 ` Linus Torvalds
2006-12-06 18:37 ` Linus Torvalds
2006-12-06 18:43 ` David Howells
2006-12-06 19:02 ` Linus Torvalds
2006-12-06 18:02 ` David Howells
2006-12-07 1:21 ` Linus Torvalds
2006-12-07 6:42 ` Andrew Morton
2006-12-07 7:49 ` Andrew Morton
2006-12-07 10:29 ` David Howells
2006-12-07 10:42 ` Andrew Morton
2006-12-07 17:05 ` Jeff Garzik
2006-12-07 17:57 ` Andrew Morton
2006-12-07 18:17 ` Andrew Morton [this message]
2006-12-08 16:52 ` [PATCH] group xtime, xtime_lock, wall_to_monotonic, avenrun, calc_load_count fields together in ktimed Eric Dumazet
2006-12-09 5:46 ` Andrew Morton
2006-12-09 6:07 ` Randy Dunlap
2006-12-11 20:44 ` Eric Dumazet
2006-12-11 22:00 ` Andrew Morton
2006-12-13 21:26 ` [PATCH] Introduce time_data, a new structure to hold jiffies, xtime, xtime_lock, wall_to_monotonic, calc_load_count and avenrun Eric Dumazet
2006-12-15 5:24 ` Andrew Morton
2006-12-15 11:21 ` Eric Dumazet
2006-12-15 16:21 ` Eric Dumazet
2006-12-07 18:08 ` [PATCH] Export current_is_keventd() for libphy Maciej W. Rozycki
2006-12-07 18:59 ` Andy Fleming
2006-12-07 16:49 ` Linus Torvalds
2006-12-07 17:52 ` Andrew Morton
2006-12-07 18:01 ` Linus Torvalds
2006-12-07 18:16 ` Andrew Morton
2006-12-07 18:27 ` Linus Torvalds
2006-12-07 15:28 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207101741.25fe647c.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=afleming@freescale.com \
--cc=ben.collins@ubuntu.com \
--cc=dhowells@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=rdreier@cisco.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox