From: Ralf Baechle <ralf@linux-mips.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [MIPS] Import updates from i386's i8259.c
Date: Thu, 7 Dec 2006 12:33:21 +0000 [thread overview]
Message-ID: <20061207123321.GB15386@linux-mips.org> (raw)
In-Reply-To: <20061207094639.GA30260@lst.de>
On Thu, Dec 07, 2006 at 10:46:39AM +0100, Christoph Hellwig wrote:
> On Wed, Dec 06, 2006 at 08:15:47PM +0000, linux-mips@linux-mips.org wrote:
> > Author: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Thu Dec 7 02:04:17 2006 +0900
> > Comitter: Ralf Baechle <ralf@linux-mips.org> Wed Dec 6 20:10:54 2006 +0000
> > Commit: bf8cfe1360932f191a3ea8d47c773c008ec32cd7
> > Gitweb: http://www.linux-mips.org/g/linux/bf8cfe13
> > Branch: master
> >
> > Import many updates from i386's i8259.c, especially genirq transitions.
>
> Shouldn't we try to share i8259.c over the various architectures that
> use this controller? With the generic hardirq framework that should be
> possible.
See http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=20061206203259.GA10170%40linux-mips.org ;-)
The MIPS version of i8259 is already sharable that is all the code that
doesn't immediately deal with the i8259 PIC has been removed. A few
small things will need still need attention. i386 uses this silly
optimization in cached_master_mask / cached_slave_mask that depends on
little endian byte order. i386 programs ICW2 with 0x20 while MIPS uses
I8259A_IRQ_BASE. And the i386 version has various stuff such as the FPU
interrupt handler which are not immediately i8259A-related in i8259.c.
Ralf
prev parent reply other threads:[~2006-12-07 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20037871AbWLFUPw/20061206201552Z+14601@ftp.linux-mips.org>
2006-12-07 9:46 ` [MIPS] Import updates from i386's i8259.c Christoph Hellwig
2006-12-07 12:33 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061207123321.GB15386@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox