public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: linux-net@vger.kernel.org, mpm@selenic.com, akpm@osdl.org,
	linux-kernel@vger.kernel.org, clalance@redhat.com
Subject: Re: [PATCH] netpoll: make arp replies through netpoll use mac address of sender
Date: Fri, 08 Dec 2006 00:07:27 -0800 (PST)	[thread overview]
Message-ID: <20061208.000727.23014207.davem@davemloft.net> (raw)
In-Reply-To: <20061207194553.GB29313@hmsreliant.homelinux.net>

From: Neil Horman <nhorman@tuxdriver.com>
Date: Thu, 7 Dec 2006 14:45:53 -0500

> Back in 2.4 arp requests that were recevied by netpoll were processed in
> netconsole_receive_skb, where they were responded to using the src mac of the
> request sender.  In the 2.6 kernel arp_reply is responsible for this function,
> but instead of using the src mac address of the incomming request, the stored
> mac address that was registered for the netconsole application is used.  While
> this is usually ok, it can lead to failures in netpoll in some situations
> (specifically situations where a network may have two gateways, as arp requests
> from one may be responded to using the mac address of the other).  This patch
> reverts the behavior to what we had in 2.4, in which all arp requests are sent
> back using the src address of the request sender.
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>

Applied, and I'll push this to -stable, thanks Neil.

But please submit networking patches next time to
netdev@vger.kernel.org, most of the networking developers did not see
this patch because you sent it to the user help list (linux-net)
instead of the developer list (netdev).

Thanks again.

  parent reply	other threads:[~2006-12-08  8:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-07 19:45 [PATCH] netpoll: make arp replies through netpoll use mac address of sender Neil Horman
2006-12-07 21:47 ` Chris Lalancette
2006-12-08  8:07 ` David Miller [this message]
2006-12-08 14:13   ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061208.000727.23014207.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=clalance@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox