* Re: [PATCH] slab: remove SLAB_KERNEL
[not found] <200612071659.kB7Gxa89031154@hera.kernel.org>
@ 2006-12-08 12:02 ` Dave Jones
2006-12-08 12:59 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2006-12-08 12:02 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: torvalds, akpm, Christoph Lameter
On Thu, Dec 07, 2006 at 04:59:36PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e94b1766097d53e6f3ccfb36c8baa562ffeda3fc
> Commit: e94b1766097d53e6f3ccfb36c8baa562ffeda3fc
> Parent: 54e6ecb23951b195d02433a741c7f7cb0b796c78
> Author: Christoph Lameter <clameter@sgi.com>
> AuthorDate: Wed Dec 6 20:33:17 2006 -0800
> Committer: Linus Torvalds <torvalds@woody.osdl.org>
> CommitDate: Thu Dec 7 08:39:24 2006 -0800
>
> [PATCH] slab: remove SLAB_KERNEL
>
> SLAB_KERNEL is an alias of GFP_KERNEL.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Missed one.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.19.noarch/mm/mmap.c~ 2006-12-08 06:51:55.000000000 -0500
+++ linux-2.6.19.noarch/mm/mmap.c 2006-12-08 06:52:05.000000000 -0500
@@ -2226,7 +2226,7 @@ int install_special_mapping(struct mm_st
struct vm_area_struct *vma;
int err;
- vma = kmem_cache_alloc(vm_area_cachep, SLAB_KERNEL);
+ vma = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
if (unlikely(vma == NULL))
return -ENOMEM;
memset(vma, 0, sizeof(*vma));
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] slab: remove SLAB_KERNEL
2006-12-08 12:02 ` [PATCH] slab: remove SLAB_KERNEL Dave Jones
@ 2006-12-08 12:59 ` Jens Axboe
2006-12-08 14:13 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2006-12-08 12:59 UTC (permalink / raw)
To: Dave Jones, Linux Kernel Mailing List, torvalds, akpm,
Christoph Lameter
On Fri, Dec 08 2006, Dave Jones wrote:
> On Thu, Dec 07, 2006 at 04:59:36PM +0000, Linux Kernel wrote:
> > Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e94b1766097d53e6f3ccfb36c8baa562ffeda3fc
> > Commit: e94b1766097d53e6f3ccfb36c8baa562ffeda3fc
> > Parent: 54e6ecb23951b195d02433a741c7f7cb0b796c78
> > Author: Christoph Lameter <clameter@sgi.com>
> > AuthorDate: Wed Dec 6 20:33:17 2006 -0800
> > Committer: Linus Torvalds <torvalds@woody.osdl.org>
> > CommitDate: Thu Dec 7 08:39:24 2006 -0800
> >
> > [PATCH] slab: remove SLAB_KERNEL
> >
> > SLAB_KERNEL is an alias of GFP_KERNEL.
> >
> > Signed-off-by: Christoph Lameter <clameter@sgi.com>
> > Signed-off-by: Andrew Morton <akpm@osdl.org>
> > Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
> Missed one.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
>
> --- linux-2.6.19.noarch/mm/mmap.c~ 2006-12-08 06:51:55.000000000 -0500
> +++ linux-2.6.19.noarch/mm/mmap.c 2006-12-08 06:52:05.000000000 -0500
> @@ -2226,7 +2226,7 @@ int install_special_mapping(struct mm_st
> struct vm_area_struct *vma;
> int err;
>
> - vma = kmem_cache_alloc(vm_area_cachep, SLAB_KERNEL);
> + vma = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
> if (unlikely(vma == NULL))
> return -ENOMEM;
> memset(vma, 0, sizeof(*vma));
What kernel is that?
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] slab: remove SLAB_KERNEL
2006-12-08 12:59 ` Jens Axboe
@ 2006-12-08 14:13 ` Dave Jones
0 siblings, 0 replies; 3+ messages in thread
From: Dave Jones @ 2006-12-08 14:13 UTC (permalink / raw)
To: Jens Axboe; +Cc: Linux Kernel Mailing List, torvalds, akpm, Christoph Lameter
On Fri, Dec 08, 2006 at 01:59:43PM +0100, Jens Axboe wrote:
> > --- linux-2.6.19.noarch/mm/mmap.c~ 2006-12-08 06:51:55.000000000 -0500
> > +++ linux-2.6.19.noarch/mm/mmap.c 2006-12-08 06:52:05.000000000 -0500
> > @@ -2226,7 +2226,7 @@ int install_special_mapping(struct mm_st
> > struct vm_area_struct *vma;
> > int err;
> >
> > - vma = kmem_cache_alloc(vm_area_cachep, SLAB_KERNEL);
> > + vma = kmem_cache_alloc(vm_area_cachep, GFP_KERNEL);
> > if (unlikely(vma == NULL))
> > return -ENOMEM;
> > memset(vma, 0, sizeof(*vma));
>
> What kernel is that?
Oops. My bad. That chunk came from execshield.
Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-08 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200612071659.kB7Gxa89031154@hera.kernel.org>
2006-12-08 12:02 ` [PATCH] slab: remove SLAB_KERNEL Dave Jones
2006-12-08 12:59 ` Jens Axboe
2006-12-08 14:13 ` Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox