From: Pete Zaitcev <zaitcev@redhat.com>
To: Erik Jacobson <erikj@sgi.com>
Cc: guillaume.thouvenin@bull.net, matthltc@us.ibm.com,
zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
Date: Fri, 8 Dec 2006 19:20:27 -0800 [thread overview]
Message-ID: <20061208192027.18a1e708.zaitcev@redhat.com> (raw)
In-Reply-To: <20061207232213.GA29340@sgi.com>
On Thu, 7 Dec 2006 17:22:13 -0600, Erik Jacobson <erikj@sgi.com> wrote:
> Here, we just adjust how the variables are declared and use memcopy to
> avoid the error messages.
> - ev->timestamp_ns = timespec_to_ns(&ts);
> + ev.timestamp_ns = timespec_to_ns(&ts);
Please try to declare u64 timestamp_ns, then copy it into the *ev
instead of copying whole *ev. This ought to fix the problem if
buffer[] ends aligned to 32 bits or better.
Also... Since Linus does not take patches in general off l-k anymore,
you have to find whoever herds the connector and feed the patch through
him/her.
-- Pete
next prev parent reply other threads:[~2006-12-09 3:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 23:22 [PATCH] connector: Some fixes for ia64 unaligned access errors Erik Jacobson
2006-12-09 3:20 ` Pete Zaitcev [this message]
2006-12-09 7:47 ` Matt Helsley
2006-12-09 21:09 ` Erik Jacobson
2006-12-10 2:34 ` Pete Zaitcev
2006-12-11 23:52 ` Matt Helsley
2006-12-12 1:29 ` Pete Zaitcev
2006-12-12 1:50 ` David Miller
2006-12-12 3:09 ` Matt Helsley
2006-12-12 3:41 ` David Miller
2006-12-12 2:07 ` Chen, Kenneth W
2006-12-11 23:52 ` Matt Helsley
2006-12-12 17:54 ` Erik Jacobson
2006-12-13 0:45 ` Andrew Morton
2006-12-13 2:31 ` Erik Jacobson
2006-12-13 2:38 ` Andrew Morton
2006-12-13 6:08 ` Erik Jacobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061208192027.18a1e708.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=erikj@sgi.com \
--cc=guillaume.thouvenin@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox