public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, Jiri Kosina <jkosina@suse.cz>,
	Marcel Holtmann <marcel@holtmann.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: [GIT PATCH] HID patches for 2.6.19
Date: Fri, 8 Dec 2006 13:12:53 -0800	[thread overview]
Message-ID: <20061208211253.GA8694@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0612081126420.3516@woody.osdl.org>

On Fri, Dec 08, 2006 at 11:28:57AM -0800, Linus Torvalds wrote:
> 
> 
> On Fri, 8 Dec 2006, Greg KH wrote:
> >
> > Here are some patches that move the HID code to a new directory allowing
> > it to be used by other kernel subsystems easier.
> 
> I pulled. However, I think the Kconfig changes are HORRIBLE.
> 
> I don't understand why people don't use "select" more. Why should Kconfig 
> ask for "Generic HID support?" That question _never_ makes sense to a 
> user. And if you answer "n", you'll not get USB_HID.
> 
> This is not user-friendly. If you need HID support, just select it. Don't 
> ask people questions that make no sense. If the generic HID code is needed 
> for some driver, you just select it. If it's not needed, you don't. It's 
> that easy.

I think some people feel we are using "select" too much at times, so
that is why it was done that way.

But in this case, yes, I do think it would make it easier for the user
if it was changed.  Jiri, care to make up a new patch that does this?

thanks,

greg k-h

      parent reply	other threads:[~2006-12-08 21:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 18:54 [GIT PATCH] HID patches for 2.6.19 Greg KH
2006-12-08 19:28 ` Linus Torvalds
2006-12-08 19:38   ` Marcel Holtmann
2006-12-08 21:34     ` Jiri Kosina
2006-12-08 21:12   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061208211253.GA8694@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@osdl.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=marcel@holtmann.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox