public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: randy.dunlap@oracle.com
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, khc@pm.waw.pl
Subject: Re: [PATCH] fix WAN routers kconfig dependency
Date: Sat, 09 Dec 2006 13:58:57 -0800 (PST)	[thread overview]
Message-ID: <20061209.135857.18290043.davem@davemloft.net> (raw)
In-Reply-To: <20061209124108.a25bb375.randy.dunlap@oracle.com>

From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Sat, 9 Dec 2006 12:41:08 -0800

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Currently WAN router drivers can be built in-kernel while the
> register/unregister_wan_device interfaces are built as modules.
> This causes:
> 
> drivers/built-in.o: In function `cycx_init':
> cycx_main.c:(.init.text+0x5c4b): undefined reference to `register_wan_device'
> drivers/built-in.o: In function `cycx_exit':
> cycx_main.c:(.exit.text+0x560): undefined reference to `unregister_wan_device'
> make: *** [.tmp_vmlinux1] Error 1
> 
> The problem is caused by tristate -> bool conversion (y or m => y),
> so convert WAN_ROUTER_DRIVERS to a tristate so that the correct
> dependency is preserved.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Applied, thanks Randy.

      reply	other threads:[~2006-12-09 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-09 20:41 [PATCH] fix WAN routers kconfig dependency Randy Dunlap
2006-12-09 21:58 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061209.135857.18290043.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox