From: Randy Dunlap <randy.dunlap@oracle.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: akpm <akpm@osdl.org>, dmitry.torokhov@gmail.com
Subject: [PATCH] ucb1400_ts depends SND_AC97_BUS
Date: Sat, 9 Dec 2006 00:36:35 -0800 [thread overview]
Message-ID: <20061209003635.e778ff76.randy.dunlap@oracle.com> (raw)
From: Randy Dunlap <randy.dunlap@oracle.com>
This driver is an AC97 codec according to its help text.
However, if SOUND is disabled, the "select SND_AC97_BUS"
still inserts that into the .config file:
#
# Sound
#
# CONFIG_SOUND is not set
CONFIG_SND_AC97_BUS=m
Even if the config software followed dependency chains on selects,
we should try to limit usage of "select" to library-type
code that is needed (e.g., CRC functions) instead of bus-type
support.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/input/touchscreen/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.19-git13.orig/drivers/input/touchscreen/Kconfig
+++ linux-2.6.19-git13/drivers/input/touchscreen/Kconfig
@@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN
config TOUCHSCREEN_UCB1400
tristate "Philips UCB1400 touchscreen"
- select SND_AC97_BUS
+ depends on SND_AC97_BUS
help
This enables support for the Philips UCB1400 touchscreen interface.
The UCB1400 is an AC97 audio codec. The touchscreen interface
---
next reply other threads:[~2006-12-09 8:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-09 8:36 Randy Dunlap [this message]
2006-12-10 2:50 ` [PATCH] ucb1400_ts depends SND_AC97_BUS Dmitry Torokhov
2006-12-10 2:57 ` Randy Dunlap
2006-12-10 3:05 ` Dmitry Torokhov
2006-12-10 3:17 ` Nicolas Pitre
2006-12-10 5:09 ` Randy Dunlap
2006-12-11 3:55 ` Nicolas Pitre
2006-12-11 4:45 ` Randy Dunlap
2008-09-05 2:57 ` Randy Dunlap
2008-09-05 4:37 ` Nicolas Pitre
2008-09-05 4:44 ` Randy Dunlap
2008-09-05 5:09 ` Nicolas Pitre
2008-09-05 6:46 ` Takashi Iwai
2008-09-05 14:52 ` Nicolas Pitre
2008-09-05 16:26 ` Takashi Iwai
2008-09-05 16:32 ` Nicolas Pitre
2008-09-05 17:17 ` Takashi Iwai
2008-09-05 18:33 ` Dmitry Torokhov
2008-09-06 9:54 ` Takashi Iwai
2008-09-05 21:09 ` Randy Dunlap
2008-09-06 9:53 ` Takashi Iwai
2008-09-05 5:27 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061209003635.e778ff76.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox