From: Olivier Galibert <galibert@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jean Delvare <khali@linux-fr.org>,
Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
Date: Sat, 9 Dec 2006 23:34:19 +0100 [thread overview]
Message-ID: <20061209223418.GA76069@dspnet.fr.eu.org> (raw)
In-Reply-To: <20061209135829.86038f32.akpm@osdl.org>
On Sat, Dec 09, 2006 at 01:58:29PM -0800, Andrew Morton wrote:
> On Sat, 9 Dec 2006 22:44:53 +0100
> Olivier Galibert <galibert@pobox.com> wrote:
> > Hmmm, I don't understand. Which is the bug, having a sysfs file
> > creation fail or going on if it happens?
>
> Probably the former, probably the latter.
>
> There may be situations in which we want do to "create this sysfs file if
> it doesn't already exist", but I'm not aware of any such.
>
> Generally speaking, if sysfs file creation went wrong, it's due to a bug.
> The result is that the driver isn't working as intended: tunables or
> instrumentation which it is designed to make available are not present. We
> want to know about that bug asap so we can get it fixed.
Hmmm, then why don't you just drop the return value from the creation
function and BUG() in there is something went wrong. That would allow
for better error messages too.
OG.
next prev parent reply other threads:[~2006-12-09 22:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061209165606.2f026a6c.khali@linux-fr.org>
2006-12-09 19:59 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Benjamin Herrenschmidt
2006-12-09 20:22 ` Muli Ben-Yehuda
2006-12-09 20:53 ` Benjamin Herrenschmidt
2006-12-09 20:38 ` Andrew Morton
2006-12-09 20:55 ` Benjamin Herrenschmidt
2006-12-09 21:44 ` Olivier Galibert
2006-12-09 21:58 ` Andrew Morton
2006-12-09 22:34 ` Olivier Galibert [this message]
2006-12-09 22:53 ` Andrew Morton
2006-12-10 0:55 ` Benjamin Herrenschmidt
2006-12-15 14:47 ` sysfs file creation result nightmare Jean Delvare
2006-12-15 20:16 ` Benjamin Herrenschmidt
2006-12-15 20:31 ` Andrew Morton
2006-12-20 8:01 ` Greg KH
2006-12-20 9:27 ` Benjamin Herrenschmidt
2006-12-11 2:46 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Paul Mackerras
2006-12-14 21:42 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061209223418.GA76069@dspnet.fr.eu.org \
--to=galibert@pobox.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox