From: Andrew Morton <akpm@osdl.org>
To: Paul Jackson <pj@sgi.com>
Cc: Jay Cliburn <jacliburn@bellsouth.net>,
linux-kernel@vger.kernel.org, clameter@sgi.com
Subject: Re: [BUG] commit 3c517a61, slab: better fallback allocation behavior
Date: Sun, 10 Dec 2006 14:14:35 -0800 [thread overview]
Message-ID: <20061210141435.afac089d.akpm@osdl.org> (raw)
In-Reply-To: <20061210124907.60c4a0aa.pj@sgi.com>
On Sun, 10 Dec 2006 12:49:07 -0800
Paul Jackson <pj@sgi.com> wrote:
> Good report - thanks.
>
> Christoph - fallback_alloc() can be called with interrupts off.
>
> I fixed the cpuset_zone_allowed() call from fallback_alloc() to avoid
> sleeping. Notice the __GFP_HARDWALL added in Linus's version, or the
> new function cpuset_zone_allowed_hardwall() in Andrew's version, all
> done in the last week.
>
> But apparently kmem_getpages() can also sleep, as it calls __alloc_pages().
>
This is lame. Please, always always test all new submissions with all the
nice kernel debugging options enabled.
They are summarised in Documentation/SubmitChecklist, along with a number
of other useful bug-prevention suggestions.
next prev parent reply other threads:[~2006-12-10 22:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 19:49 [BUG] commit 3c517a61, slab: better fallback allocation behavior Jay Cliburn
2006-12-10 20:49 ` Paul Jackson
2006-12-10 22:14 ` Andrew Morton [this message]
2006-12-11 17:13 ` Christoph Lameter
2006-12-11 17:37 ` Christoph Lameter
2006-12-11 19:41 ` Jay Cliburn
2006-12-12 18:57 ` Paul Jackson
2006-12-12 19:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061210141435.afac089d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=jacliburn@bellsouth.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox