Re: [PATCH] nbd: show nbd client pid in sysfs

[Pavel Machek <pavel@ucw.cz>]

Hi!

> > > This simple patch allows nbd to expose the nbd-client 
> > > daemon's PID in /sys/block/nbd<x>/pid. This is helpful 
> > > for tracking connection status of a device and for 
> > > determining which nbd devices are currently in use.
> > 
> > Actually is it needed at all? Perhaps nbd clients should be modified
> > to put nbdX in their process nam?
> 
> I don't think that's the right approach; only the kernel can guarantee
> that a given process is actually managing a given nbd device (I could
> have some rogue process running around announcing that it's managing
> nbd2, and then what?)

I'd say "do not run rogue processes as root" :-).

nbd-client should run as root -- I do not think interface was
carefully audited to run it as a user -- so rogue process should not
really be a problem.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html