From: Ingo Molnar <mingo@elte.hu>
To: Jarek Poplawski <jarkao2@o2.pl>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] lockdep: fix possible races while disabling lock-debugging
Date: Mon, 11 Dec 2006 08:23:02 +0100 [thread overview]
Message-ID: <20061211072302.GA31962@elte.hu> (raw)
In-Reply-To: <20061208062725.GA1012@ff.dom.local>
* Jarek Poplawski <jarkao2@o2.pl> wrote:
> > @@ -567,12 +601,10 @@ static noinline int print_circular_bug_t
> > if (debug_locks_silent)
> > return 0;
> >
> > - /* hash_lock unlocked by the header */
> > - __raw_spin_lock(&hash_lock);
> > this.class = check_source->class;
> > if (!save_trace(&this.trace))
> > return 0;
> > - __raw_spin_unlock(&hash_lock);
> > +
>
> IMHO lock is needed here for save_trace.
indeed. I'll do a fix for this.
Ingo
next prev parent reply other threads:[~2006-12-11 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 13:29 [patch] lockdep: fix possible races while disabling lock-debugging Ingo Molnar
2006-12-08 6:27 ` Jarek Poplawski
2006-12-11 7:23 ` Ingo Molnar [this message]
2006-12-11 7:28 ` [patch] lockdep: fix possible race while disabling lock-debugging, restore fix Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211072302.GA31962@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=jarkao2@o2.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox