From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Andrew MChuck Ebbert <76306.1226@compuserve.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
"Linus Torvalds orton <akpm@osdl.org>" <torvalds@osdl.org>
Subject: Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted
Date: Mon, 11 Dec 2006 10:03:01 +0000 [thread overview]
Message-ID: <20061211100301.GD4587@ftp.linux.org.uk> (raw)
In-Reply-To: <20061211014727.21c4ab25.akpm@osdl.org>
On Mon, Dec 11, 2006 at 01:47:27AM -0800, Andrew Morton wrote:
> - populate_rootfs() puts stuff into the filesystem
>
> - we then run initcalls.
>
> - an initcall runs /sbin/hotplug.
>
> We're now running userspace before all the initcalls have been executed.
> Hence we're trying to run userspace when potentially none of "grep
> _initcall */*.c" has been executed. It isn't a kernel yet...
That's... arguable. We certainly don't need lots and lots of initcalls
to be able to run userland code. Which ones are missing in your opinion?
As for that example, I'd love to see specifics - which driver triggers
hotplug? Presumably it happens from an initcall, so we also have something
fishy here...
Said that, I think that pipes should be initialized early.
next prev parent reply other threads:[~2006-12-11 10:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 8:27 [patch] pipe: Don't oops when pipe filesystem isn't mounted Chuck Ebbert
2006-12-11 8:55 ` Andrew Morton
2006-12-11 9:13 ` Andrew Morton
2006-12-11 9:21 ` Al Viro
2006-12-11 9:25 ` Andrew Morton
2006-12-11 9:33 ` Al Viro
2006-12-11 9:47 ` Andrew Morton
2006-12-11 10:03 ` Al Viro [this message]
2006-12-11 10:17 ` Andrew Morton
2006-12-11 10:22 ` Al Viro
2006-12-11 10:34 ` Andrew Morton
2006-12-11 10:47 ` Al Viro
2006-12-11 10:57 ` Jeff Garzik
2006-12-11 10:27 ` Andrew Morton
2006-12-11 10:45 ` Al Viro
2006-12-11 16:01 ` Linus Torvalds
2006-12-11 16:12 ` Al Viro
2006-12-11 16:40 ` Linus Torvalds
2006-12-12 0:33 ` Benjamin Herrenschmidt
2006-12-12 2:08 ` Andrew Morton
2006-12-12 2:17 ` Dominik Brodowski
2006-12-12 2:23 ` Linus Torvalds
2006-12-11 10:52 ` [PATCH] get rid of ARCH_HAVE_XTIME_LOCK Eric Dumazet
2006-12-11 13:50 ` [PATCH] Optimize calc_load() Eric Dumazet
2006-12-11 19:04 ` [PATCH] constify pipe_buf_operations Eric Dumazet
2006-12-11 9:13 ` [patch] pipe: Don't oops when pipe filesystem isn't mounted Al Viro
2006-12-11 9:40 ` Michael Tokarev
2006-12-11 15:44 ` Linus Torvalds
2006-12-12 12:20 ` Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 9:33 Chuck Ebbert
2006-12-11 10:48 ` Olaf Hering
2006-12-11 10:52 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211100301.GD4587@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox