Re: [PATCH 0/4] kconfig: Only activate UI save widgets when .config changed; Take 3

[Randy Dunlap <randy.dunlap@oracle.com>]

On Mon, 11 Dec 2006 14:08:51 +0100 Karsten Wiese wrote:

> Am Sonntag, 10. Dezember 2006 09:10 schrieb Andrew Morton:
> > 
> > So I'm pretending to be kbuild maintainer and I now realise I simply don't
> > know what this patch series does.
> > 
> > Can you please explain it a lot more?
> 
> lets "make xconfig" on a freshly untarred kernel-tree.
> look at the floppy disk icon of the qt application, that has just started:
> Its in a normal, active state.
> Mouse click on it:
> .config is being saved.
> Now in the current -mm head version, you'll notice something new:
> after the mouse click on the floppy disk icon, the icon is greyed out.
> If you mouse click on it now, nothing happens, which is ok IMHO,
> as nothing has changed.
> If you change some CONFIG_*, the floppy disk icon returns to "active state",
> that is, if you mouse click it now, .config is written.
> The "icon greying out" aka "save widget de/activation" is done by this
> patch series.
> Its done for the save-icons and the file-save menu entries of the
> applications launched after "make xconfig" or "make gconfig" is called.
> Purpose is: 
> "let the (gtk/qt kernel configuration) application show me if there are
>  unsaved changes to the .config,
>  so there's 1 thing less I might wonder about"
> 
> more?

I reviewed the patches and tested menu/x/gconfig.
They all look good to me.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks,
---
~Randy