From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
mingo@elte.hu, alan@lxorguk.ukuu.org.uk, lenb@kernel.org,
linux-kernel@vger.kernel.org, ak@suse.de, torvalds@osdl.org
Subject: Re: [patch] net: dev_watchdog() locking fix
Date: Mon, 11 Dec 2006 12:09:45 -0800 [thread overview]
Message-ID: <20061211120945.d75db2b4.akpm@osdl.org> (raw)
In-Reply-To: <20061211075111.GA24994@gondor.apana.org.au>
On Mon, 11 Dec 2006 18:51:11 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Sun, Dec 10, 2006 at 11:45:08PM -0800, Andrew Morton wrote:
> >
> > It spits a nasty during bringup
> >
> > e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
> > forcedeth.c: Reverse Engineered nForce ethernet driver. Version 0.59.
> > netconsole: device eth0 not up yet, forcing it
> > e1000: eth0: e1000_watchdog: NIC Link is Up 100 Mbps Full Duplex
> > WARNING (!__warned) at kernel/softirq.c:137 local_bh_enable()
>
> Normally networking isn't invoked with interrupts turned off, but
> I suppose we don't have a choice here. This is unique being a
> place where you can get called with BH on, off, or IRQs off.
>
> Given that this is only used for printk, the easiest solution is
> probably just to disable local IRQs instead of BH.
>
I'll try that. I wonder what will explode now..
next prev parent reply other threads:[~2006-12-11 20:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-06 22:30 [patch] ACPI, i686, x86_64: fix laptop bootup hang in init_acpi() Ingo Molnar
2006-12-06 23:57 ` Len Brown
2006-12-07 11:08 ` Ingo Molnar
2006-12-07 12:11 ` [patch] x86_64: do not enable the NMI watchdog by default Ingo Molnar
2006-12-07 12:30 ` Alan
2006-12-07 20:38 ` Andrew Morton
2006-12-07 20:47 ` Ingo Molnar
2006-12-07 20:49 ` Ingo Molnar
2006-12-07 20:55 ` [patch] net: dev_watchdog() locking fix Ingo Molnar
2006-12-07 21:06 ` Herbert Xu
2006-12-08 23:19 ` Andrew Morton
2006-12-08 23:59 ` Herbert Xu
2006-12-09 22:02 ` David Miller
2006-12-11 7:45 ` Andrew Morton
2006-12-11 7:51 ` Herbert Xu
2006-12-11 7:56 ` Ingo Molnar
2006-12-11 20:09 ` Andrew Morton [this message]
2006-12-07 17:24 ` [patch] x86_64: do not enable the NMI watchdog by default Andi Kleen
2006-12-07 2:28 ` [patch] ACPI, i686, x86_64: fix laptop bootup hang in init_acpi() Sergio Monteiro Basto
2006-12-07 4:47 ` Karsten Wiese
2006-12-07 11:09 ` Ingo Molnar
2006-12-07 11:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211120945.d75db2b4.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox