From: Olaf Hering <olaf@aepfle.de>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Herbert Poetzl <herbert@13thfloor.at>, Andi Kleen <ak@suse.de>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Steve Fox <drfickle@us.ibm.com>
Subject: Re: 2.6.19-git13: uts banner changes break SLES9 (at least)
Date: Mon, 11 Dec 2006 17:33:34 +0100 [thread overview]
Message-ID: <20061211163333.GA17947@aepfle.de> (raw)
In-Reply-To: <457D750C.9060807@shadowen.org>
On Mon, Dec 11, Andy Whitcroft wrote:
> # get_kernel_version /boot/vmlinuz-autobench
> %s
It expects the content from `cat /proc/version`:
...
for (i = 0; i < in; i++)
if (buffer[i] == 'L' && buffer[i+1] == 'i' &&
buffer[i+2] == 'n' && buffer[i+3] == 'u' &&
buffer[i+4] == 'x' && buffer[i+5] == ' ' &&
buffer[i+6] == 'v' && buffer[i+7] == 'e' &&
buffer[i+8] == 'r' && buffer[i+9] == 's' &&
buffer[i+10] == 'i' && buffer[i+11] == 'o' &&
buffer[i+12] == 'n' && buffer[i+13] == ' ')
{
found = 1;
break;
}
...
The change breaks the assumption:
const char linux_banner[] =
- "Linux version " UTS_RELEASE " (" LINUX_COMPILE_BY "@"
- LINUX_COMPILE_HOST ") (" LINUX_COMPILER ") " UTS_VERSION "\n";
+ "Linux version %s (" LINUX_COMPILE_BY "@"
+ LINUX_COMPILE_HOST ") (" LINUX_COMPILER ") %s\n";
Please revert this change.
next prev parent reply other threads:[~2006-12-11 16:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 15:11 2.6.19-git13: uts banner changes break SLES9 (at least) Andy Whitcroft
2006-12-11 16:33 ` Olaf Hering [this message]
2006-12-11 16:44 ` Linus Torvalds
2006-12-11 16:52 ` Linus Torvalds
2006-12-11 18:04 ` Olaf Hering
2006-12-11 18:18 ` Olaf Hering
2006-12-11 18:26 ` Linus Torvalds
2006-12-11 18:29 ` Herbert Poetzl
2006-12-11 18:43 ` Linus Torvalds
2006-12-11 18:55 ` Olaf Hering
2006-12-11 19:11 ` Linus Torvalds
2006-12-11 22:04 ` Paul Mackerras
2006-12-12 0:05 ` David Miller
2006-12-12 9:10 ` Gerd Hoffmann
2006-12-11 19:20 ` Andy Whitcroft
2006-12-11 19:36 ` Linus Torvalds
2006-12-11 22:42 ` Andy Whitcroft
2006-12-11 19:37 ` Herbert Poetzl
2006-12-11 19:56 ` Olaf Hering
2006-12-11 20:05 ` Linus Torvalds
2006-12-11 20:09 ` Linus Torvalds
2006-12-11 20:21 ` Greg KH
2006-12-11 20:16 ` Olaf Hering
2006-12-11 20:15 ` Theodore Tso
2006-12-11 20:23 ` Arjan van de Ven
2006-12-11 21:16 ` H. Peter Anvin
2006-12-11 18:49 ` Olaf Hering
2006-12-12 12:23 ` Mach-O binary format support and Darwin syscall personality [Was: uts banner changes] Kyle Moffett
2006-12-12 16:23 ` Linus Torvalds
2006-12-12 17:56 ` Kyle Moffett
2006-12-12 18:20 ` Linus Torvalds
2006-12-12 22:34 ` Kyle Moffett
2006-12-12 22:38 ` Benjamin Herrenschmidt
2006-12-12 22:57 ` Linus Torvalds
2006-12-12 22:21 ` Benjamin Herrenschmidt
2006-12-15 12:53 ` Pavel Machek
2006-12-11 17:50 ` 2.6.19-git13: uts banner changes break SLES9 (at least) Olaf Hering
2006-12-11 17:57 ` Arjan van de Ven
2006-12-11 18:00 ` Olaf Hering
2006-12-11 18:08 ` Arjan van de Ven
2006-12-11 18:14 ` Olaf Hering
2006-12-11 19:03 ` Arjan van de Ven
2006-12-11 19:37 ` Jan Engelhardt
2006-12-11 18:19 ` Linus Torvalds
2006-12-11 18:40 ` Olaf Hering
2006-12-11 18:52 ` Linus Torvalds
2006-12-11 19:34 ` Jan Engelhardt
2006-12-11 21:15 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061211163333.GA17947@aepfle.de \
--to=olaf@aepfle.de \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=drfickle@us.ibm.com \
--cc=herbert@13thfloor.at \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox