* Make OLPC camera driver depend on x86.
@ 2006-12-12 14:52 Dave Jones
2006-12-12 15:12 ` Jonathan Corbet
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2006-12-12 14:52 UTC (permalink / raw)
To: Linux Kernel; +Cc: corbet
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.19.noarch/drivers/media/video/Kconfig~ 2006-12-12 09:51:16.000000000 -0500
+++ linux-2.6.19.noarch/drivers/media/video/Kconfig 2006-12-12 09:51:32.000000000 -0500
@@ -668,7 +668,7 @@ config VIDEO_M32R_AR_M64278
config VIDEO_CAFE_CCIC
tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
- depends on I2C && VIDEO_V4L2
+ depends on I2C && VIDEO_V4L2 && X86_32
select VIDEO_OV7670
---help---
This is a video4linux2 driver for the Marvell 88ALP01 integrated
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make OLPC camera driver depend on x86.
2006-12-12 14:52 Make OLPC camera driver depend on x86 Dave Jones
@ 2006-12-12 15:12 ` Jonathan Corbet
2006-12-12 15:39 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Jonathan Corbet @ 2006-12-12 15:12 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones <davej@redhat.com> wrote:
> - depends on I2C && VIDEO_V4L2
> + depends on I2C && VIDEO_V4L2 && X86_32
Any particular reason why? I wouldn't be surprised to see Cafe used
with other processors in the future. And I happen to know the driver
works on x86-64 systems...or at least it did a few iterations back.
In any case, x86 for now is fine, I guess; we can always change it later
if need be.
jon
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make OLPC camera driver depend on x86.
2006-12-12 15:12 ` Jonathan Corbet
@ 2006-12-12 15:39 ` Dave Jones
2006-12-12 17:40 ` Alan
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2006-12-12 15:39 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: linux-kernel
On Tue, Dec 12, 2006 at 08:12:52AM -0700, Jonathan Corbet wrote:
> Dave Jones <davej@redhat.com> wrote:
>
> > - depends on I2C && VIDEO_V4L2
> > + depends on I2C && VIDEO_V4L2 && X86_32
>
> Any particular reason why?
Just seemed odd to be offered the option when I was building
an ia64 kernel given its extremely unlikely to ever appear there.
[gads, an ia64 olpc, what a thought...]
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make OLPC camera driver depend on x86.
2006-12-12 15:39 ` Dave Jones
@ 2006-12-12 17:40 ` Alan
2006-12-12 17:42 ` Dave Jones
0 siblings, 1 reply; 6+ messages in thread
From: Alan @ 2006-12-12 17:40 UTC (permalink / raw)
To: Dave Jones; +Cc: Jonathan Corbet, linux-kernel
On Tue, 12 Dec 2006 10:39:56 -0500
Dave Jones <davej@redhat.com> wrote:
> On Tue, Dec 12, 2006 at 08:12:52AM -0700, Jonathan Corbet wrote:
> > Dave Jones <davej@redhat.com> wrote:
> >
> > > - depends on I2C && VIDEO_V4L2
> > > + depends on I2C && VIDEO_V4L2 && X86_32
> >
> > Any particular reason why?
>
> Just seemed odd to be offered the option when I was building
> an ia64 kernel given its extremely unlikely to ever appear there.
It means we catch portability bugs early and people changing core code
catch problems even if their platform is not X86_32. The practice for
almost all out drivers is thus not to put in arch dependancies unless
they genuinely do not build on arbitary platforms.
NAK
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make OLPC camera driver depend on x86.
2006-12-12 17:40 ` Alan
@ 2006-12-12 17:42 ` Dave Jones
0 siblings, 0 replies; 6+ messages in thread
From: Dave Jones @ 2006-12-12 17:42 UTC (permalink / raw)
To: Alan; +Cc: Jonathan Corbet, linux-kernel
On Tue, Dec 12, 2006 at 05:40:55PM +0000, Alan Cox wrote:
> > > > - depends on I2C && VIDEO_V4L2
> > > > + depends on I2C && VIDEO_V4L2 && X86_32
> > >
> > > Any particular reason why?
> >
> > Just seemed odd to be offered the option when I was building
> > an ia64 kernel given its extremely unlikely to ever appear there.
>
> It means we catch portability bugs early and people changing core code
> catch problems even if their platform is not X86_32. The practice for
> almost all out drivers is thus not to put in arch dependancies unless
> they genuinely do not build on arbitary platforms.
>
> NAK
Given this could in theory turn up in USB form one day, and some
lunatic may actually plug one into an ia64, I see your point.
Unlikely, but feasible.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Make OLPC camera driver depend on x86.
@ 2006-12-12 23:49 Chuck Ebbert
0 siblings, 0 replies; 6+ messages in thread
From: Chuck Ebbert @ 2006-12-12 23:49 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel, Jonathan Corbet
In-Reply-To: <20061212153956.GH8509@redhat.com>
On Tue, 12 Dec 2006 10:39:56 -0500, Dave Jones wrote:
> [gads, an ia64 olpc, what a thought...]
Teacher in front of a classroom full of students, all madly
pedaling away on stationary bicycles: "Okay, class, just another
hour of this and we can use the computers for a few minutes."
--
MBTI: IXTP
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-12-13 0:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-12 14:52 Make OLPC camera driver depend on x86 Dave Jones
2006-12-12 15:12 ` Jonathan Corbet
2006-12-12 15:39 ` Dave Jones
2006-12-12 17:40 ` Alan
2006-12-12 17:42 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2006-12-12 23:49 Chuck Ebbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox