From: Adrian Bunk <bunk@stusta.de>
To: kkeil@suse.de, kai.germaschewski@gmx.de
Cc: isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/isdn/pcbit/: proper prototypes
Date: Tue, 12 Dec 2006 17:24:16 +0100 [thread overview]
Message-ID: <20061212162416.GV28443@stusta.de> (raw)
This patch adds correct prototypes in header files for global functions
and variables.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/isdn/pcbit/drv.c | 4 ----
drivers/isdn/pcbit/edss1.c | 6 ------
drivers/isdn/pcbit/edss1.h | 7 +++++--
drivers/isdn/pcbit/layer2.c | 16 ----------------
drivers/isdn/pcbit/module.c | 3 ---
drivers/isdn/pcbit/pcbit.h | 8 +++++++-
6 files changed, 12 insertions(+), 32 deletions(-)
--- linux-2.6.19-mm1/drivers/isdn/pcbit/edss1.h.old 2006-12-12 15:00:56.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/edss1.h 2006-12-12 15:09:07.000000000 +0100
@@ -90,9 +90,12 @@
unsigned long timeout; /* in seconds */
};
+extern char * isdn_state_table[];
+
+void pcbit_fsm_event(struct pcbit_dev *, struct pcbit_chan *,
+ unsigned short event, struct callb_data *);
+char * strisdnevent(ushort ev);
-extern void pcbit_fsm_event(struct pcbit_dev *, struct pcbit_chan *,
- unsigned short event, struct callb_data *);
#endif
--- linux-2.6.19-mm1/drivers/isdn/pcbit/pcbit.h.old 2006-12-12 15:03:03.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/pcbit.h 2006-12-12 15:07:40.000000000 +0100
@@ -166,6 +166,12 @@
#define L2_RUNNING 5
#define L2_ERROR 6
-extern void pcbit_deliver(struct work_struct *work);
+void pcbit_deliver(struct work_struct *work);
+int pcbit_init_dev(int board, int mem_base, int irq);
+void pcbit_terminate(int board);
+void pcbit_l3_receive(struct pcbit_dev * dev, ulong msg, struct sk_buff * skb,
+ ushort hdr_len, ushort refnum);
+void pcbit_state_change(struct pcbit_dev * dev, struct pcbit_chan * chan,
+ unsigned short i, unsigned short ev, unsigned short f);
#endif
--- linux-2.6.19-mm1/drivers/isdn/pcbit/drv.c.old 2006-12-12 15:01:38.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/drv.c 2006-12-12 15:01:53.000000000 +0100
@@ -774,10 +774,6 @@
dev->dev_if->statcallb(&ictl);
}
-extern char * isdn_state_table[];
-extern char * strisdnevent(unsigned short);
-
-
void pcbit_state_change(struct pcbit_dev * dev, struct pcbit_chan * chan,
unsigned short i, unsigned short ev, unsigned short f)
{
--- linux-2.6.19-mm1/drivers/isdn/pcbit/module.c.old 2006-12-12 15:03:34.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/module.c 2006-12-12 15:03:45.000000000 +0100
@@ -32,9 +32,6 @@
static int num_boards;
struct pcbit_dev * dev_pcbit[MAX_PCBIT_CARDS];
-extern void pcbit_terminate(int board);
-extern int pcbit_init_dev(int board, int mem_base, int irq);
-
static int __init pcbit_init(void)
{
int board;
--- linux-2.6.19-mm1/drivers/isdn/pcbit/layer2.c.old 2006-12-12 15:06:48.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/layer2.c 2006-12-12 15:07:01.000000000 +0100
@@ -47,22 +47,6 @@
#undef DEBUG_FRAG
-
-/*
- * task queue struct
- */
-
-
-
-/*
- * Layer 3 packet demultiplexer
- * drv.c
- */
-
-extern void pcbit_l3_receive(struct pcbit_dev *dev, ulong msg,
- struct sk_buff *skb,
- ushort hdr_len, ushort refnum);
-
/*
* Prototypes
*/
--- linux-2.6.19-mm1/drivers/isdn/pcbit/edss1.c.old 2006-12-12 15:07:50.000000000 +0100
+++ linux-2.6.19-mm1/drivers/isdn/pcbit/edss1.c 2006-12-12 15:07:59.000000000 +0100
@@ -35,12 +35,6 @@
#include "callbacks.h"
-extern void pcbit_state_change(struct pcbit_dev *, struct pcbit_chan *,
- unsigned short i, unsigned short ev,
- unsigned short f);
-
-extern struct pcbit_dev * dev_pcbit[MAX_PCBIT_CARDS];
-
char * isdn_state_table[] = {
"Closed",
"Call initiated",
reply other threads:[~2006-12-12 16:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212162416.GV28443@stusta.de \
--to=bunk@stusta.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kai.germaschewski@gmx.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox