From: Erik Jacobson <erikj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Erik Jacobson <erikj@sgi.com>,
linux-kernel@vger.kernel.org, guillaume.thouvenin@bull.net,
matthltc@us.ibm.com
Subject: Re: [PATCH] connector: Some fixes for ia64 unaligned access errors
Date: Tue, 12 Dec 2006 20:31:32 -0600 [thread overview]
Message-ID: <20061213023132.GA29897@sgi.com> (raw)
In-Reply-To: <20061212164504.d6f8a3cb.akpm@osdl.org>
> But it's rather a lot of churn for such a thing. Did you consider simply using
> put_unaligned() against the specific offending field(s)?
Hi. This was not considered.
I wanted to give you some quick feedback, so I tried your suggestion in the
fork path. It seemed to fix the problem as well.
put_unaligned(timespec_to_ns(&ts), (__u64 *) &ev->timestamp_ns);
Is what I tried.
I'm on vacation tomorrow but on Thursday, if you like, I can whip up
a patch that does this and test it more thoroughly. Is this the
direction you prefer? What I did just now was really quick and dirty
to see if it has a shot or not but it looks like put_unaligned will
fix it too.
--
Erik Jacobson - Linux System Software - SGI - Eagan, Minnesota
next prev parent reply other threads:[~2006-12-13 2:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 23:22 [PATCH] connector: Some fixes for ia64 unaligned access errors Erik Jacobson
2006-12-09 3:20 ` Pete Zaitcev
2006-12-09 7:47 ` Matt Helsley
2006-12-09 21:09 ` Erik Jacobson
2006-12-10 2:34 ` Pete Zaitcev
2006-12-11 23:52 ` Matt Helsley
2006-12-12 1:29 ` Pete Zaitcev
2006-12-12 1:50 ` David Miller
2006-12-12 3:09 ` Matt Helsley
2006-12-12 3:41 ` David Miller
2006-12-12 2:07 ` Chen, Kenneth W
2006-12-11 23:52 ` Matt Helsley
2006-12-12 17:54 ` Erik Jacobson
2006-12-13 0:45 ` Andrew Morton
2006-12-13 2:31 ` Erik Jacobson [this message]
2006-12-13 2:38 ` Andrew Morton
2006-12-13 6:08 ` Erik Jacobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061213023132.GA29897@sgi.com \
--to=erikj@sgi.com \
--cc=akpm@osdl.org \
--cc=guillaume.thouvenin@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox