From: Len Brown <lenb@kernel.org>
To: Holger Macht <hmacht@suse.de>,
Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Brandon Philips <brandon@ifup.org>
Subject: Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.
Date: Thu, 14 Dec 2006 17:23:20 -0500 [thread overview]
Message-ID: <200612141723.20565.lenb@kernel.org> (raw)
In-Reply-To: <20061214071631.GA6575@homac2.gate.uni-erlangen.de>
On Thursday 14 December 2006 02:16, Holger Macht wrote:
> On Mon 11. Dec - 12:05:08, Kristen Carlson Accardi wrote:
> > Ok - how is this?
>
> Looks good to me, thanks!
> > Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
>
> Signed-off-by: Holger Macht <hmacht@suse.de>
Applied.
thanks,
-Len
commit 8ea86e0ba7c9d16ae0f35cb0c4165194fa573f7a
Author: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Date: Mon Dec 11 12:05:08 2006 -0800
ACPI: dock: add uevent to indicate change in device status
Send a uevent to indicate a device change whenever we dock or
undock, so that userspace may now check the dock status via sysfs.
Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
Signed-off-by: Holger Macht <hmacht@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 8c6828b..215f5b3 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -326,10 +326,12 @@ static void hotplug_dock_devices(struct dock_station
*ds, u32 event)
static void dock_event(struct dock_station *ds, u32 event, int num)
{
+ struct device *dev = &dock_device.dev;
/*
- * we don't do events until someone tells me that
- * they would like to have them.
+ * Indicate that the status of the dock station has
+ * changed.
*/
+ kobject_uevent(&dev->kobj, KOBJ_CHANGE);
}
/**
next prev parent reply other threads:[~2006-12-14 23:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061204224037.713257809@localhost.localdomain>
2006-12-04 22:49 ` [patch 1/3] Make the dock station driver a platform device driver Kristen Carlson Accardi
2006-12-04 22:49 ` [patch 2/3] acpi: Add a docked sysfs file to the dock driver Kristen Carlson Accardi
2006-12-09 11:59 ` Holger Macht
2006-12-11 20:05 ` Kristen Carlson Accardi
2006-12-12 22:15 ` Stefan Schmidt
2006-12-12 22:31 ` Jesse Barnes
2006-12-12 23:00 ` Kristen Carlson Accardi
2006-12-12 23:26 ` Stefan Schmidt
2006-12-13 9:14 ` Kay Sievers
2006-12-13 9:56 ` Stefan Schmidt
2006-12-14 7:16 ` Holger Macht
2006-12-14 22:23 ` Len Brown [this message]
2006-12-04 22:50 ` [patch 3/3] acpi: Fix symbol conflict between acpiphp and dock Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612141723.20565.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=brandon@ifup.org \
--cc=hmacht@suse.de \
--cc=kristen.c.accardi@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox