From: Jens Axboe <jens.axboe@oracle.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: "'linux-kernel'" <linux-kernel@vger.kernel.org>
Subject: Re: [patch] speed up single bio_vec allocation
Date: Thu, 14 Dec 2006 21:23:44 +0100 [thread overview]
Message-ID: <20061214202343.GK5010@kernel.dk> (raw)
In-Reply-To: <000001c71b16$4ca91b90$d134030a@amr.corp.intel.com>
On Fri, Dec 08 2006, Chen, Kenneth W wrote:
> > Chen, Kenneth wrote on Wednesday, December 06, 2006 10:20 AM
> > > Jens Axboe wrote on Wednesday, December 06, 2006 2:09 AM
> > > This is what I had in mind, in case it wasn't completely clear. Not
> > > tested, other than it compiles. Basically it eliminates the small
> > > bio_vec pool, and grows the bio by 16-bytes on 64-bit archs, or by
> > > 12-bytes on 32-bit archs instead and uses the room at the end for the
> > > bio_vec structure.
> >
> > Yeah, I had a very similar patch queued internally for the large benchmark
> > measurement. I will post the result as soon as I get it.
>
>
> Jens, this improves 0.25% on our db transaction processing benchmark setup.
> The patch tested is (on top of 2.6.19):
> http://marc.theaimsgroup.com/?l=linux-kernel&m=116539972229021&w=2
Ok, well it's not much but if it's significant it's not too bad either
:-)
Some tests I ran locally showed it being _slower_, which is a little
odd. They were basically hammering requests through the block layer with
a null end.
--
Jens Axboe
next prev parent reply other threads:[~2006-12-14 20:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 22:14 [patch] speed up single bio_vec allocation Chen, Kenneth W
2006-12-14 20:23 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-04 19:27 Chen, Kenneth W
2006-12-04 20:06 ` Jens Axboe
2006-12-04 20:36 ` Chen, Kenneth W
2006-12-04 20:43 ` Jens Axboe
2006-12-06 10:08 ` Jens Axboe
2006-12-06 10:56 ` Jens Axboe
2006-12-06 18:19 ` Chen, Kenneth W
2006-12-07 19:22 ` Nate Diller
2006-12-07 19:36 ` Chen, Kenneth W
2006-12-07 21:46 ` Nate Diller
2006-12-07 21:52 ` Chen, Kenneth W
2006-12-07 22:33 ` Nate Diller
2006-12-08 8:01 ` Jens Axboe
2006-12-08 2:27 ` Andi Kleen
2006-12-08 4:23 ` Chen, Kenneth W
2006-12-08 4:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214202343.GK5010@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox