Re: [git patches] libata updates

Jeff Garzik
2006-03-21T01:12:32Z

Alan Cox wrote:
> On Llu, 2006-03-20 at 06:16 -0500, Jeff Garzik wrote:
>
>>Jeff Garzik:
>> [libata] Move PCI IDE BMDMA-related code to new file libata-bmdma.c.
>
>
> This is a most confusing choice as 80% of the file has nothing to do
> with bus mastering DMA, and a large amount of it has nothing to do with
> PCI either. Also lots of DMA stuff is in the drivers so all the new bus
> mastering drivers don't use bmdma.c
>
> The split makes sense, the choice of name is peculiar, if not completely
> broken 8)

Peculiar? Probably... :)

In my [no doubt warped] brain, I equate the SFF-8038 interface to "PCI
IDE BMDMA", and from there, view most hardware as a subset of PCI IDE
BMDMA. It might not do DMA, might not be PCI, might not do irqs, but
most PATA hardware seems able to be driven by a "bmdma driver". Thus,
the name :)

Jeff