* [PATCH 2.6.20-rc1] fix vm_events_fold_cpu() build breakage
@ 2006-12-15 3:06 Magnus Damm
2006-12-16 18:35 ` Christoph Lameter
0 siblings, 1 reply; 3+ messages in thread
From: Magnus Damm @ 2006-12-15 3:06 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Magnus Damm, Christoph Lameter
fix vm_events_fold_cpu() build breakage
2.6.20-rc1 does not build properly if CONFIG_VM_EVENT_COUNTERS is set
and CONFIG_HOTPLUG is unset:
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
mm/built-in.o: In function `page_alloc_cpu_notify':
page_alloc.c:(.text+0x56eb): undefined reference to `vm_events_fold_cpu'
make: *** [.tmp_vmlinux1] Error 1
Signed-Off-By: Magnus Damm <magnus@valinux.co.jp>
---
Applies on top of linux-2.6.20-rc1.
include/linux/vmstat.h | 4 ++++
1 file changed, 4 insertions(+)
--- 0001/include/linux/vmstat.h
+++ 0003/include/linux/vmstat.h 2006-12-15 11:46:23.000000000 +0900
@@ -73,7 +73,11 @@ static inline void count_vm_events(enum
}
extern void all_vm_events(unsigned long *);
+#ifdef CONFIG_HOTPLUG
extern void vm_events_fold_cpu(int cpu);
+#else
+#define vm_events_fold_cpu(x) do { } while (0)
+#endif
#else
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.20-rc1] fix vm_events_fold_cpu() build breakage
2006-12-15 3:06 [PATCH 2.6.20-rc1] fix vm_events_fold_cpu() build breakage Magnus Damm
@ 2006-12-16 18:35 ` Christoph Lameter
2006-12-17 15:10 ` Jean Delvare
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Lameter @ 2006-12-16 18:35 UTC (permalink / raw)
To: Magnus Damm; +Cc: Linux Kernel Mailing List
On Fri, 15 Dec 2006, Magnus Damm wrote:
> fix vm_events_fold_cpu() build breakage
Acked-by: Christoph Lameter <clameter@sgi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2.6.20-rc1] fix vm_events_fold_cpu() build breakage
2006-12-16 18:35 ` Christoph Lameter
@ 2006-12-17 15:10 ` Jean Delvare
0 siblings, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2006-12-17 15:10 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Magnus Damm, Linux Kernel Mailing List, Andrew Morton
On Sat, 16 Dec 2006 10:35:29 -0800 (PST), Christoph Lameter wrote:
> On Fri, 15 Dec 2006, Magnus Damm wrote:
>
> > fix vm_events_fold_cpu() build breakage
>
> Acked-by: Christoph Lameter <clameter@sgi.com>
I've hit that one too. Can this fix be sent upstream quickly please?
Thanks,
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-12-17 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-15 3:06 [PATCH 2.6.20-rc1] fix vm_events_fold_cpu() build breakage Magnus Damm
2006-12-16 18:35 ` Christoph Lameter
2006-12-17 15:10 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox