From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, holzheu@de.ibm.com
Subject: Re: [S390] Fix reboot hang on LPARs
Date: Fri, 15 Dec 2006 22:15:58 +0100 [thread overview]
Message-ID: <20061215211558.GA8101@osiris.ibm.com> (raw)
In-Reply-To: <20061215162218.GF4920@skybase>
> +static int pgm_check_occured;
> +
> +static void cio_reset_pgm_check_handler(void)
> +{
> + pgm_check_occured = 1;
> +}
> +
> +static int stsch_reset(struct subchannel_id schid, volatile struct schib *addr)
> +{
> + int rc;
> +
> + pgm_check_occured = 0;
> + s390_reset_pgm_handler = cio_reset_pgm_check_handler;
> + rc = stsch(schid, addr);
> + s390_reset_pgm_handler = NULL;
> + if (pgm_check_occured)
> + return -EIO;
> + else
> + return rc;
> +}
This is broken. pgm_check_occured must be volatile, otherwise the -EIO path
in stsch_reset might get optimized away.
next prev parent reply other threads:[~2006-12-15 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 16:22 [S390] Fix reboot hang on LPARs Martin Schwidefsky
2006-12-15 21:15 ` Heiko Carstens [this message]
2006-12-16 10:31 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061215211558.GA8101@osiris.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=holzheu@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).