From: Al Viro <viro@ftp.linux.org.uk>
To: Pavel Machek <pavel@ucw.cz>
Cc: rmk@arm.linux.org.uk, rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>,
Dirk@Opfer-Online.de, arminlitzel@web.de, pavel.urban@ct.cz,
metan@seznam.cz
Subject: Re: Nasty warnings on arm (+ one compile problem -- INIT_WORK related)
Date: Sat, 16 Dec 2006 01:07:02 +0000 [thread overview]
Message-ID: <20061216010702.GB17561@ftp.linux.org.uk> (raw)
In-Reply-To: <20061215235818.GD2853@elf.ucw.cz>
On Sat, Dec 16, 2006 at 12:58:18AM +0100, Pavel Machek wrote:
> Hi!
>
> I get nasty warning for each file compiled:
>
> CC drivers/video/sa1100fb.o
> In file included from include/asm/bitops.h:23,
> from include/linux/bitops.h:9,
> from include/linux/thread_info.h:20,
> from include/linux/preempt.h:9,
> from include/linux/spinlock.h:49,
> from include/linux/module.h:9,
> from drivers/video/sa1100fb.c:163:
> include/asm/system.h: In function `adjust_cr':
> include/asm/system.h:185: warning: implicit declaration of function
> `local_irq_save'
> include/asm/system.h:192: warning: implicit declaration of function
> `local_irq_restore'
> include/asm/system.h:179: warning: unused variable `cr'
That's dealt with by the following:
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/include/asm-arm/system.h b/include/asm-arm/system.h
index e160aeb..bf44782 100644
--- a/include/asm-arm/system.h
+++ b/include/asm-arm/system.h
@@ -173,10 +173,12 @@ static inline void set_copro_access(unsi
extern unsigned long cr_no_alignment; /* defined in entry-armv.S */
extern unsigned long cr_alignment; /* defined in entry-armv.S */
+#include <linux/irqflags.h>
+
#ifndef CONFIG_SMP
static inline void adjust_cr(unsigned long mask, unsigned long set)
{
- unsigned long flags, cr;
+ unsigned long flags;
mask &= ~CR_A;
@@ -248,8 +250,6 @@ static inline void sched_cacheflush(void
{
}
-#include <linux/irqflags.h>
-
#ifdef CONFIG_SMP
#define smp_mb() mb()
next prev parent reply other threads:[~2006-12-16 1:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 23:58 Nasty warnings on arm (+ one compile problem -- INIT_WORK related) Pavel Machek
2006-12-16 1:07 ` Al Viro [this message]
2006-12-16 1:09 ` Al Viro
2006-12-17 12:33 ` Pavel Machek
2006-12-16 12:10 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061216010702.GB17561@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=Dirk@Opfer-Online.de \
--cc=arminlitzel@web.de \
--cc=lenz@cs.wisc.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=metan@seznam.cz \
--cc=pavel.urban@ct.cz \
--cc=pavel@ucw.cz \
--cc=rmk@arm.linux.org.uk \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox