From: Adrian Bunk <bunk@stusta.de>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] include linux/types.h in a bunch of header files for usage with install_headers
Date: Sat, 16 Dec 2006 03:33:52 +0100 [thread overview]
Message-ID: <20061216023352.GZ3388@stusta.de> (raw)
In-Reply-To: <8bd0f97a0612151808h2aafaf61nf7c29a1cb1962135@mail.gmail.com>
On Fri, Dec 15, 2006 at 09:08:50PM -0500, Mike Frysinger wrote:
> On 12/12/06, Adrian Bunk <bunk@stusta.de> wrote:
> >On Wed, Dec 06, 2006 at 06:03:50PM -0500, Mike Frysinger wrote:
> >> there are a plethora of headers that cannot be included straight due
> >> to the usage of __ types (like __u32) without first including
> >> linux/types.h ... so the question is, should all of these headers be
> >> fixed to properly pull in linux/types.h first or are users expected to
> >> "just know" the correct order of headers ? in my mind, pretty much
> >> every header is fair game for straight "#include <header>" usage and
> >> requiring a list of headers to be pulled in properly is ignoring the
> >> problem ...
> >
> >Yes, they should all be fixed to #include <linux/types.h>.
>
> thanks, mondo patch attached :)
Looks good, but after your patch the following headers can be moved from
unifdef-y to header-y:
include/linux/atm.h
include/linux/atmarp.h
> -mike
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2006-12-16 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 2:08 [patch] include linux/types.h in a bunch of header files for usage with install_headers Mike Frysinger
2006-12-16 2:33 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061216023352.GZ3388@stusta.de \
--to=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox