From: Ingo Molnar <mingo@elte.hu>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13
Date: Sun, 17 Dec 2006 10:09:43 +0100 [thread overview]
Message-ID: <20061217090943.GA9246@elte.hu> (raw)
In-Reply-To: <20061217085859.GB2938@elte.hu>
the other thing that is pretty ugly is the recursive_enter/clear/exit
code. I'd suggest the lockdep model here: use a single flag in
task_struct to detect recursion. Also, never use BUG() when hitting a
bug in a debugging helper - that will crash the box. Use a flag to turn
off the whole thing if you encounter an internal bug and print a
warning. That way bugs can actually be reported, instead of users
wondering why the box locked up under X.
Ingo
next prev parent reply other threads:[~2006-12-17 9:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 15:34 [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13 Catalin Marinas
2006-12-16 15:34 ` [PATCH 2.6.20-rc1 01/10] Base support for kmemleak Catalin Marinas
2006-12-16 15:34 ` [PATCH 2.6.20-rc1 02/10] Kmemleak documentation Catalin Marinas
2006-12-16 15:34 ` [PATCH 2.6.20-rc1 03/10] Add the memory allocation/freeing hooks for kmemleak Catalin Marinas
2006-12-16 15:34 ` [PATCH 2.6.20-rc1 04/10] Modules support " Catalin Marinas
2006-12-16 15:35 ` [PATCH 2.6.20-rc1 05/10] Add kmemleak support for i386 Catalin Marinas
2006-12-16 15:35 ` [PATCH 2.6.20-rc1 06/10] Add kmemleak support for ARM Catalin Marinas
2006-12-16 15:35 ` [PATCH 2.6.20-rc1 07/10] Remove some of the kmemleak false positives Catalin Marinas
2006-12-16 15:35 ` [PATCH 2.6.20-rc1 08/10] Keep the __init functions after initialization Catalin Marinas
2006-12-16 15:35 ` [PATCH 2.6.20-rc1 09/10] Testing module for kmemleak Catalin Marinas
2006-12-16 15:36 ` [PATCH 2.6.20-rc1 10/10] Update the MAINTAINERS file " Catalin Marinas
2006-12-16 16:57 ` [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13 Ingo Molnar
2006-12-16 23:39 ` Catalin Marinas
2006-12-17 8:58 ` Ingo Molnar
2006-12-17 9:09 ` Ingo Molnar [this message]
2006-12-17 9:28 ` Ingo Molnar
2006-12-17 9:41 ` Ingo Molnar
2006-12-17 9:49 ` Ingo Molnar
2006-12-17 12:05 ` Catalin Marinas
2006-12-27 16:14 ` Catalin Marinas
2006-12-27 16:23 ` Arjan van de Ven
2006-12-27 16:30 ` Catalin Marinas
2006-12-27 16:47 ` Ingo Molnar
2006-12-27 16:56 ` Ingo Molnar
2006-12-27 17:02 ` Catalin Marinas
2006-12-17 11:58 ` Catalin Marinas
2006-12-17 13:28 ` Ingo Molnar
2006-12-17 11:09 ` Mike Galbraith
2006-12-17 23:05 ` Catalin Marinas
2006-12-18 7:29 ` Ingo Molnar
2006-12-18 10:28 ` Catalin Marinas
2006-12-18 11:21 ` Ingo Molnar
2006-12-18 12:26 ` Catalin Marinas
2006-12-18 19:56 ` Ingo Molnar
2006-12-19 9:36 ` Catalin Marinas
2006-12-27 13:52 ` Catalin Marinas
2006-12-27 15:08 ` Ingo Molnar
2006-12-27 17:30 ` Ingo Molnar
2006-12-28 0:15 ` Catalin Marinas
2006-12-28 9:44 ` Ingo Molnar
2006-12-28 11:50 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061217090943.GA9246@elte.hu \
--to=mingo@elte.hu \
--cc=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox