Re: kobject.h with HOTPLUG=n

Greg KH
2006-12-18T20:11:43Z

On Mon, Dec 18, 2006 at 09:49:24AM -0800, Randy Dunlap wrote:
> In 2.6.20-rc1-mm1, with HOTPLUG=n, 2 linux/kobject.h inline functions
> need to return <int>. Currently this causes 962 warnings like this:
>
> include/linux/kobject.h: In function 'kobject_uevent':
> include/linux/kobject.h:277: warning: no return statement in function
> returning non-void
> include/linux/kobject.h: In function 'kobject_uevent_env':
> include/linux/kobject.h:281: warning: no return statement in function
> returning non-void
>
> Should these functions return 0 or some error code?
>
> static inline int kobject_uevent(struct kobject *kobj, enum kobject_action
> action) { }
> static inline int kobject_uevent_env(struct kobject *kobj,
> enum kobject_action action,
> char *envp[])
> { }

They should just return 0. Care to make up a quick patch to fix this?

thanks,

greg k-h