public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [PATCH] Remove reference to "depends" directive from Kconfig documentation.
Date: Mon, 18 Dec 2006 17:35:22 +0100	[thread overview]
Message-ID: <20061218163522.GE10316@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0612181038560.26878@localhost.localdomain>

On Mon, Dec 18, 2006 at 10:40:25AM -0500, Robert P. J. Day wrote:
> 
>   Remove from the documentation the notion of using "depends" rather
> than "depends on" in Kconfig files.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
>   given that there are only three Kconfig files left that still use
> "depends" rather than "depends on", there's no point encouraging
> anyone to still use it (although the parser itself still accepts both
> "depends" and "requires").
> 
> 
> diff --git a/Documentation/kbuild/kconfig-language.txt b/Documentation/kbuild/kconfig-language.txt
> index 536d5bf..658abb5 100644
> --- a/Documentation/kbuild/kconfig-language.txt
> +++ b/Documentation/kbuild/kconfig-language.txt
> @@ -77,7 +77,7 @@ applicable everywhere (see syntax).
>    Optionally, dependencies only for this default value can be added with
>    "if".
> 
> -- dependencies: "depends on"/"requires" <expr>
> +- dependencies: "depends on" <expr>
>    This defines a dependency for this menu entry. If multiple
>    dependencies are defined, they are connected with '&&'. Dependencies
>    are applied to all other options within this menu entry (which also

Your patch does something different:
It's not about "depends", it's about the unused alternative "requires".

Removing "requires" sounds reasonable (even for the implementation, not 
only the documentation), but that's different from what you were 
thinking about.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2006-12-18 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18 15:40 [PATCH] Remove reference to "depends" directive from Kconfig documentation Robert P. J. Day
2006-12-18 16:35 ` Adrian Bunk [this message]
2006-12-18 16:38   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061218163522.GE10316@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox