From: David Brownell <david-b@pacbell.net>
To: Paul Sokolovsky <pmiscml@gmail.com>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>,
kernel-discuss@handhelds.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)
Date: Mon, 18 Dec 2006 16:59:11 -0800 [thread overview]
Message-ID: <200612181659.11473.david-b@pacbell.net> (raw)
In-Reply-To: <200612181654.30864.david-b@pacbell.net>
On Monday 18 December 2006 4:54 pm, David Brownell wrote:
> > http://handhelds.org/cgi-bin/cvsweb.cgi/linux/kernel26/drivers/rtc/rtc-sa1100.c.diff?r1=1.5&r2=1.6&f=h
>
> That patch you applied looks right to me -- why don't you forward it
> to Alessandro as a bugfix for 2.6.20-rc2, and save me the effort?
Actually, correction: it'd be correct if you ripped out the buggy
calls to manage the irq wake mechanism. A later message will show
how those need to work. (The IRQ framework will give one helpful
hint when it warns about mismatched enable/disable calls ...)
- Dave
next prev parent reply other threads:[~2006-12-19 0:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-17 19:30 [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w) Paul Sokolovsky
2006-12-18 4:28 ` David Brownell
2006-12-18 23:58 ` Paul Sokolovsky
2006-12-19 0:54 ` David Brownell
2006-12-19 0:59 ` David Brownell [this message]
2006-12-19 6:41 ` Paul Sokolovsky
2006-12-19 9:06 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612181659.11473.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alessandro.zummo@towertech.it \
--cc=kernel-discuss@handhelds.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmiscml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox