Re: [2.6 patch] kconfig: remove the unused "requires" syntax

Robert P. J. Day
2006-12-18T19:44:07Z

On Mon, 18 Dec 2006, Adrian Bunk wrote:

> On Mon, Dec 18, 2006 at 01:46:27PM -0500, Robert P. J. Day wrote:

> > p.s. i didn't look closely enough to see if your patch took out
> > support for both "depends" *and* "requires". at this point,
> > neither of those are necessary anymore -- it's all "depends on"
> > except for three remaining Kconfig files.
>
> It takes out only "requires" (as the patch description says).

which makes perfect sense, of course.

> Whether to remove the plain "depends" (opposed to "depends on") is a
> different (and perhaps more controversial) question, but it should
> anyway not happen before the last usage is removed.

agreed on that last point. my patch submission to change "depends" to
"depends on" globally *did* get applied recently:

commit 775ba7ad491a154f99871fe603f03366e84ae159
Merge: d940505... 18b36c7...
Author: Linus Torvalds <torvalds@woody.osdl.org>
Date: Tue Dec 12 18:51:51 2006 -0800

Merge git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial

* git://git.kernel.org/pub/scm/linux/kernel/git/bunk/trivial:
...
kconfig: Standardize "depends" -> "depends on" in Kconfig files
...

so it's clear that that transformation was approved. now we just wait
for the patch to deal with the last three files to go through and
we're all set.

$ grep "depends" $(find . -name Kconfig) | grep -v "depends on"
./arch/arm/mm/Kconfig: depends !MMU && CPU_CP15 && !CPU_ARM740T
./arch/arm/Kconfig: depends CPU_XSCALE || CPU_XSC3
./arch/v850/Kconfig: depends !V850E2_SIM85E2C

rday