Re: [2.6 patch] kconfig: remove the unused "requires" syntax

Adrian Bunk
2006-12-18T19:31:12Z

On Mon, Dec 18, 2006 at 01:46:27PM -0500, Robert P. J. Day wrote:
> On Mon, 18 Dec 2006, Adrian Bunk wrote:
>
> > On Mon, Dec 18, 2006 at 11:41:59AM -0500, Robert P. J. Day wrote:
> > >
> > > Remove the note in the documentation that suggests people can use
> > > "requires" for dependencies in Kconfig files.
> > >...
> >
> > Considering that noone uses it, what about the patch below to also
> > remove the implementation?
>
> ... big snip ...
>
> i have no problem knocking out of the parser anything related to
> "depends" or "requires." in fact, i did note in earlier patch
> submissions that i was just cleaning the Kconfig files but i was
> leaving the parser alone, and someone else was welcome to take care of
> that.
>
> if the kbuild folks are good with this, i certainly have no objection.
>
> rday
>
> p.s. i didn't look closely enough to see if your patch took out
> support for both "depends" *and* "requires". at this point, neither
> of those are necessary anymore -- it's all "depends on" except for
> three remaining Kconfig files.

It takes out only "requires" (as the patch description says).

Whether to remove the plain "depends" (opposed to "depends on") is a
different (and perhaps more controversial) question, but it should
anyway not happen before the last usage is removed.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed