From: Greg KH <greg@kroah.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, kay.sievers@vrfy.org
Subject: Re: kobject.h with HOTPLUG=n
Date: Mon, 18 Dec 2006 11:51:15 -0800 [thread overview]
Message-ID: <20061218195115.GA11312@kroah.com> (raw)
In-Reply-To: <4586D4A4.5060309@oracle.com>
On Mon, Dec 18, 2006 at 09:49:24AM -0800, Randy Dunlap wrote:
> In 2.6.20-rc1-mm1, with HOTPLUG=n, 2 linux/kobject.h inline functions
> need to return <int>. Currently this causes 962 warnings like this:
>
> include/linux/kobject.h: In function 'kobject_uevent':
> include/linux/kobject.h:277: warning: no return statement in function
> returning non-void
> include/linux/kobject.h: In function 'kobject_uevent_env':
> include/linux/kobject.h:281: warning: no return statement in function
> returning non-void
>
> Should these functions return 0 or some error code?
>
> static inline int kobject_uevent(struct kobject *kobj, enum kobject_action
> action) { }
> static inline int kobject_uevent_env(struct kobject *kobj,
> enum kobject_action action,
> char *envp[])
> { }
They should just return 0. Care to make up a quick patch to fix this?
thanks,
greg k-h
next prev parent reply other threads:[~2006-12-18 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 17:49 kobject.h with HOTPLUG=n Randy Dunlap
2006-12-18 19:51 ` Greg KH [this message]
2006-12-18 20:41 ` [PATCH] " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061218195115.GA11312@kroah.com \
--to=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox