From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
Christoph Raisch <raisch@de.ibm.com>
Subject: [PATCH] ehca: fix do_mmap() error check
Date: Tue, 19 Dec 2006 17:43:57 +0900 [thread overview]
Message-ID: <20061219084357.GG4049@APFDCB5C> (raw)
The return value of do_mmap() should be checked by IS_ERR().
Cc: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
Cc: Christoph Raisch <raisch@de.ibm.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/infiniband/hw/ehca/ehca_uverbs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: 2.6-mm/drivers/infiniband/hw/ehca/ehca_uverbs.c
===================================================================
--- 2.6-mm.orig/drivers/infiniband/hw/ehca/ehca_uverbs.c
+++ 2.6-mm/drivers/infiniband/hw/ehca/ehca_uverbs.c
@@ -321,14 +321,14 @@ int ehca_mmap_nopage(u64 foffset, u64 le
struct vm_area_struct **vma)
{
down_write(¤t->mm->mmap_sem);
- *mapped = (void*)do_mmap(NULL,0, length, PROT_WRITE,
+ *mapped = (void*)do_mmap(NULL, 0, length, PROT_WRITE,
MAP_SHARED | MAP_ANONYMOUS,
foffset);
up_write(¤t->mm->mmap_sem);
- if (!(*mapped)) {
+ if (IS_ERR(*mapped)) {
ehca_gen_err("couldn't mmap foffset=%lx length=%lx",
foffset, length);
- return -EINVAL;
+ return PTR_ERR(*mmaped);
}
*vma = find_vma(current->mm, (u64)*mapped);
next reply other threads:[~2006-12-19 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 8:43 Akinobu Mita [this message]
2006-12-19 9:32 ` [PATCH] ehca: fix do_mmap() error check Hoang-Nam Nguyen
2006-12-19 11:35 ` mmap abuse in ehca, was " Christoph Hellwig
2006-12-20 8:36 ` do we have mmap abuse in ehca ?, was Re: mmap abuse in ehca Christoph Raisch
2006-12-20 11:51 ` Christoph Hellwig
2007-01-04 21:20 ` Roland Dreier
2007-01-05 8:17 ` Christoph Raisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219084357.GG4049@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=hnguyen@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox