From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Vojtech Pavlik <vojtech@suse.cz>
Subject: [PATCH] pc110pad: return proper error
Date: Tue, 19 Dec 2006 17:44:53 +0900 [thread overview]
Message-ID: <20061219084453.GH4049@APFDCB5C> (raw)
According to the comment, "if we find any PCI devices in the machine,
we don't have a PC110" in pc110pad.c, we should return -ENODEV
rather than -ENOENT in this case.
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/input/mouse/pc110pad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: 2.6-mm/drivers/input/mouse/pc110pad.c
===================================================================
--- 2.6-mm.orig/drivers/input/mouse/pc110pad.c
+++ 2.6-mm/drivers/input/mouse/pc110pad.c
@@ -113,7 +113,7 @@ static int __init pc110pad_init(void)
dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, NULL);
if (dev) {
pci_dev_put(dev);
- return -ENOENT;
+ return -ENODEV;
}
if (!request_region(pc110pad_io, 4, "pc110pad")) {
next reply other threads:[~2006-12-19 8:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 8:44 Akinobu Mita [this message]
2006-12-21 5:44 ` [PATCH] pc110pad: return proper error Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219084453.GH4049@APFDCB5C \
--to=akinobu.mita@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox