* [PATCH] tlclk: delete unnecessary sysfs_remove_group
@ 2006-12-19 8:57 Akinobu Mita
0 siblings, 0 replies; only message in thread
From: Akinobu Mita @ 2006-12-19 8:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Sebastien Bouchard, Mark Gross
It is unnecessary and invalid to call sysfs_remove_group()
after sysfs_create_group() failure.
Cc: Sebastien Bouchard <sebastien.bouchard@ca.kontron.com>
Cc: Mark Gross <mark.gross@intel.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
drivers/char/tlclk.c | 2 --
1 file changed, 2 deletions(-)
Index: 2.6-mm/drivers/char/tlclk.c
===================================================================
--- 2.6-mm.orig/drivers/char/tlclk.c
+++ 2.6-mm/drivers/char/tlclk.c
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
&tlclk_attribute_group);
if (ret) {
printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
- sysfs_remove_group(&tlclk_device->dev.kobj,
- &tlclk_attribute_group);
goto out5;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-19 8:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-19 8:57 [PATCH] tlclk: delete unnecessary sysfs_remove_group Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox