From: Ben Dooks <ben-linux@fluff.org>
To: Akinobu Mita <akinobu.mita@gmail.com>,
linux-kernel@vger.kernel.org, Wim Van Sebroeck <wim@iguana.be>,
Ben Dooks <ben@simtec.co.uk>,
Dimitry Andric <dimitry.andric@tomtom.com>
Subject: Re: [PATCH] watchdog: fix clk_get() error check
Date: Tue, 19 Dec 2006 10:43:35 +0000 [thread overview]
Message-ID: <20061219104335.GG11640@trinity.fluff.org> (raw)
In-Reply-To: <20061219085144.GI4049@APFDCB5C>
On Tue, Dec 19, 2006 at 05:51:44PM +0900, Akinobu Mita wrote:
> The return value of clk_get() should be checked by IS_ERR().
thanks for spotting this, but this will probably clash with
a cleanup patch I sent a day or two ago to streamline the
exit path in the driver.
see http://lkml.org/lkml/2006/12/18/65
--
Ben
Q: What's a light-year?
A: One-third less calories than a regular year.
next prev parent reply other threads:[~2006-12-19 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-19 8:51 [PATCH] watchdog: fix clk_get() error check Akinobu Mita
2006-12-19 10:43 ` Ben Dooks [this message]
2006-12-19 21:22 ` Wim Van Sebroeck
2006-12-19 21:20 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061219104335.GG11640@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=akinobu.mita@gmail.com \
--cc=ben@simtec.co.uk \
--cc=dimitry.andric@tomtom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox