public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	Andi Kleen <ak@suse.de>
Subject: Re: [patch] x86_64: fix boot time hang in detect_calgary()
Date: Wed, 20 Dec 2006 10:28:28 -0500	[thread overview]
Message-ID: <20061220152828.GF31335@redhat.com> (raw)
In-Reply-To: <20061220105332.GA20922@elte.hu>

On Wed, Dec 20, 2006 at 11:53:32AM +0100, Ingo Molnar wrote:

 > the patch below fixes the boot hang by trusting the BIOS-supplied data 
 > structure a bit less: the parser always has to make forward progress, 
 > and if it doesnt, we break out of the loop and i get the expected kernel 
 > message:
 > 
 >   Calgary: Unable to locate Rio Grande Table in EBDA - bailing!

Good job tracking this down.  I saw someone get bit by probably this
same bug a few days ago.  Whilst on the subject though, can we do
something about the printk ?
It always bothered me that some drivers print something when
a) built-in, and b) they don't find something.
For kitchen sink kernels, this makes for a really noisy bootup.

So you didn't find hardware I know I don't have. Big deal, move on.
dmesg spam these days is getting really out of hand.

hmm, maybe a mod_printk, to only printk something when built as
a module ?

		Dave

-- 
http://www.codemonkey.org.uk

  parent reply	other threads:[~2006-12-20 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 10:53 [patch] x86_64: fix boot time hang in detect_calgary() Ingo Molnar
2006-12-20 11:34 ` Muli Ben-Yehuda
2006-12-20 11:53   ` Muli Ben-Yehuda
2006-12-20 15:28 ` Dave Jones [this message]
2006-12-20 15:48   ` Muli Ben-Yehuda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061220152828.GF31335@redhat.com \
    --to=davej@redhat.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox